Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scroll completions menu to new selection on filter, fix corner case #23478

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mgsloan
Copy link
Contributor

@mgsloan mgsloan commented Jan 22, 2025

In the future if filter was used more this would fix other issues. In the current code paths, this just fixes the particular corner case of edit prediction arriving async while y_flipped = true (in this case it needs to be scrolled down to show item with index 0).

Release Notes:

  • N/A

In the future if `filter` was used more this would fix other issues.  In the current code paths, this just fixes the particular corner case of edit prediction arriving async while `y_flipped = true` (in this case it needs to be scrolled down to show item with index 0).
@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Jan 22, 2025
@mgsloan mgsloan enabled auto-merge (squash) January 22, 2025 17:39
@mgsloan mgsloan merged commit 09fe1e7 into main Jan 22, 2025
12 checks passed
@mgsloan mgsloan deleted the completions-menu-filter-scroll-corner-case branch January 22, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant