-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
assistant2: Revise thread visual design #23083
Merged
danilo-leal
merged 18 commits into
zed-industries:main
from
danilo-leal:revise-assistant2-thread-visual-design
Jan 14, 2025
Merged
assistant2: Revise thread visual design #23083
danilo-leal
merged 18 commits into
zed-industries:main
from
danilo-leal:revise-assistant2-thread-visual-design
Jan 14, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cla-bot
bot
added
the
cla-signed
The user has signed the Contributor License Agreement
label
Jan 13, 2025
@danilo-leal : What do you think about this one, where it shows the type of assistant used: Initially, the full text is displayed: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adjusts the design of the assistant 2 threads with the goal of reducing visual busyness. My intention is to remove the amount of lines and borders given it is a relatively tight space. It also refines the "generating" floating container style, finally leveraging linear gradients that were recently added to GPUI! Now, we only display headers for "you" messages. Assistant responses will be rendered right in the panel; not bounded by a card container.
Release Notes: