Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruby: Move Ruby extension to zed-extensions/ruby repo #19098

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

notpeter
Copy link
Member

@notpeter notpeter commented Oct 11, 2024

Removes the Ruby extension from the zed tree to https://github.com/zed-extensions/ruby. I used git-filter-repo to generate a synthetic git commit history with a new main tip of zed-extensions/ruby@961cecc. All the historical changes are retained as new commits. I documented the process I used here:

And used the following expressions.txt

php/ruby: ==>
ruby: ==>
extension: ==>
chore: ==>
zed_extension_api: ==>
regex:(?<![\[a-zA-Z0-9])(#[0-9]{3,5})==>zed-industries/zed\1

TODO:

If anyone has an feedback/fixes for the synthetic commit history, let me know. It's easy to rerun now and impossible (impractical) to do so later.

Release Notes:

  • N/A

@cla-bot cla-bot bot added the cla-signed The user has signed the Contributor License Agreement label Oct 11, 2024
@zed-industries-bot
Copy link

Messages
📖

This PR includes links to the following GitHub Issues: #19075
If this PR aims to close an issue, please include a Closes #ISSUE line at the top of the PR body.

Generated by 🚫 dangerJS against 5159368

@notpeter notpeter self-assigned this Oct 11, 2024
@maxdeviant
Copy link
Member

Synthetic commit history looks great! Cool that you figured out how to rewrite the PR references back into the Zed repo rather than removing them entirely.

@vitallium
Copy link
Contributor

I think that looks great. Thanks!

notpeter added a commit to zed-industries/extensions that referenced this pull request Oct 15, 2024
@notpeter notpeter merged commit 5445f89 into main Oct 15, 2024
13 checks passed
@notpeter notpeter deleted the ruby_extension_extraction branch October 15, 2024 19:41
@notpeter
Copy link
Member Author

notpeter commented Oct 15, 2024

For future reference, I missed one thing in modifying the history:
From Cargo.toml we need to remove this:

[lints]
workspace = true

I think it's ok for this transition, but next time I'll modify the steps in EXTRACTION.md to also filter that from the commit history too.

Anyways, new version is available under Extensions in-app:
Screenshot 2024-10-15 at 15 45 27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed The user has signed the Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ruby: Permission to extract the extension to an external repo
4 participants