Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ice Ice Bergy theme #1472

Merged
merged 5 commits into from
Oct 7, 2024
Merged

Add Ice Ice Bergy theme #1472

merged 5 commits into from
Oct 7, 2024

Conversation

jmsdnns
Copy link
Contributor

@jmsdnns jmsdnns commented Sep 30, 2024

Similar to Iceberg, but I find it's easier on the eyes. Screenshots available here: https://github.com/jmsdnns/zed-iceicebergy.

@cla-bot cla-bot bot added the cla-signed label Sep 30, 2024
@jmsdnns
Copy link
Contributor Author

jmsdnns commented Oct 1, 2024

Hmm. From what I can tell, the check didn't fail because of my theme. The log output suggests it is something to do with a package called kanagawa-themes.

Packaging 'iceicebergy'. Version: 0.3.14
Checking out Git submodule at 'extensions/iceicebergy'

Packaging 'kanagawa-themes'. Version: 0.0.1
Checking out Git submodule at 'extensions/kanagawa-themes'
file:///home/runner/work/extensions/extensions/src/package-extensions.js:148
    throw new Error(
          ^

Error: The `extension.json` manifest format has been superseded by `extension.toml`
    at packageExtension (file:///home/runner/work/extensions/extensions/src/package-extensions.js:148:11)
    at async file:///home/runner/work/extensions/extensions/src/package-extensions.js:119:5

Node.js v20.17.0
 ELIFECYCLE  Command failed with exit code 1.

@jmsdnns
Copy link
Contributor Author

jmsdnns commented Oct 1, 2024

To simplify things, the error says to use extension.toml. The one in my theme is right here: https://github.com/jmsdnns/zed-iceicebergy/blob/main/extension.toml

@maxdeviant
Copy link
Member

Hmm. From what I can tell, the check didn't fail because of my theme. The log output suggests it is something to do with a package called kanagawa-themes.

Packaging 'iceicebergy'. Version: 0.3.14
Checking out Git submodule at 'extensions/iceicebergy'

Packaging 'kanagawa-themes'. Version: 0.0.1
Checking out Git submodule at 'extensions/kanagawa-themes'
file:///home/runner/work/extensions/extensions/src/package-extensions.js:148
    throw new Error(
          ^

Error: The `extension.json` manifest format has been superseded by `extension.toml`
    at packageExtension (file:///home/runner/work/extensions/extensions/src/package-extensions.js:148:11)
    at async file:///home/runner/work/extensions/extensions/src/package-extensions.js:119:5

Node.js v20.17.0
 ELIFECYCLE  Command failed with exit code 1.

Your branch needed to be updated with the latest changes from main.

Copy link
Member

@maxdeviant maxdeviant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@maxdeviant maxdeviant merged commit d74120e into zed-industries:main Oct 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants