Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate hardened-only Sapling ZIP 32 test vectors #94

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

str4d
Copy link
Contributor

@str4d str4d commented Nov 22, 2023

No description provided.

RIPEMD support was removed from OpenSSL by default, and thus hashlib.
@@ -0,0 +1,8 @@
[
["From https://github.com/zcash-hackworks/zcash-test-vectors/blob/master/sapling_zip32.py"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This URI is now incorrect.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's been incorrect for a while, both due to internal refactoring to poetry and the recent repository move. This should be fixed separately across the entire test vector corpus.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK. I have not attempted to regenerate these locally, but CI verifies this so it should be fine.

@str4d str4d merged commit ddb3397 into master Dec 1, 2023
3 checks passed
@str4d str4d deleted the zip32-sapling-hard branch December 1, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants