Add vector generation for bundle commitments. #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is currently conflicting with |
nuttycom
force-pushed
the
orchard_merkle_tree
branch
from
f4d7564
to
8d8fca7
Compare
str4d
reviewed
Aug 30, 2021
| def main(): | ||
| args = render_args() | ||
|
|
||
| bundle_commitments = [ |
There was a problem hiding this comment.
This should not be in this file (this is where #36 will go). These should go into a separate script file (they aren't really what this repo is for, but there isn't any better place to put them).
There was a problem hiding this comment.
Document how these were generated, in case they need to be regenerated.
r3ld3v
modified the milestones:
Core Sprint 2022-04,
Core Sprint 2022-06,
Core Sprint 2022-08
|
Once #74 is complete, this should be closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit awkward, because the test vectors it generates are not
complete; it merely generates anchors for the bundle commitments
from https://github.com/zcash/zcash/pull/5233/files?file-filters%5B%5D=.cpp&file-filters%5B%5D=.h&file-filters%5B%5D=.hpp#diff-38ff85a72cad7fe2516912a84c7deedb725cc444d230a6d1accfc1258ecff005
The serialized bundle values there were generated in a non-reproducible
fashion from the librustzcash property tests, then the note commitments
were extracted so as to be able to generate just the anchors.