Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add auto-shielding to the data access API #341

Merged
merged 90 commits into from
Feb 2, 2022
Merged

Add auto-shielding to the data access API #341

merged 90 commits into from
Feb 2, 2022

Commits on Apr 16, 2021

  1. PoC Auto-Shielding 

    Add retrieval of transparent UTXOs to WalletRead

Co-authored-by: Kris Nuttycombe <[email protected]>
Co-authored-by: Kevin Gorham <[email protected]>
    @pacu @nuttycom @gmale
    3 people committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    cff457f View commit details
    Browse the repository at this point in the history

  2. Put transparent dependencies behind a feature flag.

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    862e221 View commit details
    Browse the repository at this point in the history

  3. Add WIF derivation for transparent keys. 

    With @gmale
    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    ca3e3a4 View commit details
    Browse the repository at this point in the history

  4. Rename get_spendable -> get_unspent

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    a3bc1e3 View commit details
    Browse the repository at this point in the history

  5. Add confirmation depth to shield_funds

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    b88ee47 View commit details
    Browse the repository at this point in the history

  6. Query for unspent utxos checks to ensure that spending tx is mined. 

    Also make it an error to try to send a memo to a transparent address.
    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    8828276 View commit details
    Browse the repository at this point in the history

  7. Store vout as part of store_decrypted_tx

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    13cd749 View commit details
    Browse the repository at this point in the history

  8. Figure out the account ID for z->t spends.

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    665c4c7 View commit details
    Browse the repository at this point in the history

  9. Add public key derivations and related tests.

    @nuttycom
    Kevin Gorham authored and nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    5595ca2 View commit details
    Browse the repository at this point in the history

  10. Insert into accounts table with taddrs.

    @nuttycom
    Kevin Gorham authored and nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    bdf5692 View commit details
    Browse the repository at this point in the history

  11. Update accounts table create statement. 

    This PR makes the opinionated change that T-addrs are required
to be supported when using the zcash_client_sqlite backend.
    @nuttycom
    Kevin Gorham authored and nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    8e16d93 View commit details
    Browse the repository at this point in the history

  12. Add ZIP-321 request based sends to zcash_client_backend.

    @nuttycom
    nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    9b3025d View commit details
    Browse the repository at this point in the history

  13. Ensure that rewinds go far enough to properly restore incremental wit… 

    …ness state.
    @nuttycom
    Kevin Gorham authored and nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    bb68744 View commit details
    Browse the repository at this point in the history

  14. Add get_all_nullifiers.

    @nuttycom
    Kevin Gorham authored and nuttycom committed Apr 16, 2021
    Configuration menu
    Copy the full SHA
    c1bc069 View commit details
    Browse the repository at this point in the history

Commits on Apr 20, 2021

  1. Placeholder commit: just get things working. 

    Clean up later but for now don't allow nullable accountIds and also delete more data, during a rewind.
    Kevin Gorham committed Apr 20, 2021
    Configuration menu
    Copy the full SHA
    7fc2d97 View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Fix: get rewind height when there are no unspent notes. 

    Previously, this function was not properly returning an optional.
    Kevin Gorham committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    74434f3 View commit details
    Browse the repository at this point in the history

Commits on May 1, 2021

  1. Add clear function for the accounts table.

    Kevin Gorham committed May 1, 2021
    Configuration menu
    Copy the full SHA
    08a5cfa View commit details
    Browse the repository at this point in the history

  2. Drop accounts table instead. 

    We need to recreate the table each time it is cleared to handle any migrations. This is mostly a stop-gap measure until the migrations and table creations are handled by the same code.
    Kevin Gorham committed May 1, 2021
    Configuration menu
    Copy the full SHA
    5a51003 View commit details
    Browse the repository at this point in the history

Commits on May 4, 2021

  1. Relax fk constraints.

    Kevin Gorham committed May 4, 2021
    Configuration menu
    Copy the full SHA
    3828a81 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2021

  1. Remove drop accounts function.

    Kevin Gorham committed May 7, 2021
    Configuration menu
    Copy the full SHA
    bd65b01 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2021

  1. Minor code cleanup.

    @nuttycom
    nuttycom committed May 14, 2021
    Configuration menu
    Copy the full SHA
    8e3e7de View commit details
    Browse the repository at this point in the history

  2. Merge pull request #10 from gmale/autoshield-poc-daa-taddr3 

    Changes to support internal ECC release
    @nuttycom
    nuttycom authored May 14, 2021
    Configuration menu
    Copy the full SHA
    5540f36 View commit details
    Browse the repository at this point in the history

  3. Fix missing method in in-memory wallet prototype.

    @nuttycom
    nuttycom committed May 14, 2021
    Configuration menu
    Copy the full SHA
    fd47ee3 View commit details
    Browse the repository at this point in the history

Commits on Aug 12, 2021

  1. Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa

    @nuttycom
    nuttycom committed Aug 12, 2021
    Configuration menu
    Copy the full SHA
    b783c4d View commit details
    Browse the repository at this point in the history

Commits on Aug 27, 2021

  1. Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa

    @nuttycom
    nuttycom committed Aug 27, 2021
    Configuration menu
    Copy the full SHA
    edd7471 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Always take number of confirmations as a parameter.

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    2053d7f View commit details
    Browse the repository at this point in the history

  2. Address documentation & naming requests from code review.

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    db89569 View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'upstream/master' into autoshield-poc-re… 

    …order
    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    6cf0749 View commit details
    Browse the repository at this point in the history

  4. Modify WalletTransparentOutput to wrap TxOut directly.

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d49a20e View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review & update changelog 

    Co-authored-by: str4d <[email protected]>
Co-authored-by: Daira Hopwood <[email protected]>
    @nuttycom @str4d @daira
    3 people committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    d43a893 View commit details
    Browse the repository at this point in the history

  6. Enforce maximum zip321 payment count in TransactionRequest constructor.

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    e30c5cd View commit details
    Browse the repository at this point in the history

  7. Update hdwallet to depend upon secp256k1-v0.20

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    da3c84f View commit details
    Browse the repository at this point in the history

  8. Fix transitivity of the test-dependencies feature.

    @nuttycom
    nuttycom committed Oct 1, 2021
    Configuration menu
    Copy the full SHA
    74b0c50 View commit details
    Browse the repository at this point in the history

Commits on Oct 4, 2021

  1. Fix zcash_client_backend doctest

    @nuttycom
    nuttycom committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    86da943 View commit details
    Browse the repository at this point in the history

  2. Feature-flag transparent functionality in zcash_client_sqlite 

    This fixes the wasm32-wasi build issues by excluding the
hdwallet dependencies which are not wasm32-wasi compatible.
    @nuttycom
    nuttycom committed Oct 4, 2021
    Configuration menu
    Copy the full SHA
    cc58a21 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2021

  1. Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa

    @nuttycom
    nuttycom committed Oct 25, 2021
    Configuration menu
    Copy the full SHA
    fc0dd8e View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2021

  1. Merge remote-tracking branch 'upstream/master' into autoshield-poc-daa

    @nuttycom
    nuttycom committed Nov 24, 2021
    Configuration menu
    Copy the full SHA
    0b9d7e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 20, 2022

  1. Merge remote-tracking branch 'upstream/non-consensus-changes-on-branc… 

    …hid-37519621' into autoshield-poc-daa
    @nuttycom
    nuttycom committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    3dd1f31 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Daira Hopwood <[email protected]>
Co-authored-by: ying tong <[email protected]>
    @nuttycom @daira @therealyingtong
    3 people committed Jan 20, 2022
    Configuration menu
    Copy the full SHA
    37e6d3a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2022

  1. Add newtypes for transparent keys at the account & external levels. 

    This updates UnifiedFullViewingKey to conform to ZIP 316, and
adds types that facilitate this support. These types should likely
be factored out from `zcash_client_backend` into `zcash_primitives`
along with the remainder of the existing unified address support.
    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    ffc4d0c View commit details
    Browse the repository at this point in the history

  2. Add missing documentation & rustfmt.

    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    79bd2f7 View commit details
    Browse the repository at this point in the history

  3. Document wallet database initialization.

    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    f75ffb0 View commit details
    Browse the repository at this point in the history

  4. Remove cyclic dev dependency between zcash_client_backend and zcash_c… 

    …lient_sqlite.
    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    8f40835 View commit details
    Browse the repository at this point in the history

  5. Add unified spending keys.

    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    dec395a View commit details
    Browse the repository at this point in the history

  6. Add accessors for the ExtendedPubKey wrapped by AccountPubKey

    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    00aee09 View commit details
    Browse the repository at this point in the history

  7. Add convenience method for amount sums.

    @nuttycom
    nuttycom committed Jan 21, 2022
    Configuration menu
    Copy the full SHA
    7c03dbd View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2022

  1. Add accessors for the ExtendedPrivKey wrapped by AccountPrivKey

    @nuttycom
    nuttycom committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    281a4d5 View commit details
    Browse the repository at this point in the history

  2. Add accessors to UnifiedSpendingKey

    @nuttycom
    nuttycom committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    574ca4e View commit details
    Browse the repository at this point in the history

  3. Fix test compilation errors related to UFVK construction.

    @nuttycom
    nuttycom committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    7d873e9 View commit details
    Browse the repository at this point in the history

  4. Fix a minor naming error in AccountPubKey

    @nuttycom
    nuttycom committed Jan 22, 2022
    Configuration menu
    Copy the full SHA
    15eb5aa View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2022

  1. zcash_primitives: Do not gate secp256k1 on transparent-inputs feature… 

    … flag.
    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    1f9b9fc View commit details
    Browse the repository at this point in the history

  2. Move ExternalPrivKey, ExternalPubKey to zcash_primitives.

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    a4c9f53 View commit details
    Browse the repository at this point in the history

  3. zip316::transparent: Implement ZIP 316 transparent internal ovk.

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    5033d29 View commit details
    Browse the repository at this point in the history

  4. Use transparent internal ovk in shield_transparent_funds().

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    c9fe840 View commit details
    Browse the repository at this point in the history

  5. zcash_primitives::zip316::transparent: Parse Ufvk from zcash_address.

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    6f776aa View commit details
    Browse the repository at this point in the history

  6. Implement TryFrom<&[u8] for ExternalPubKey.

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    a7ea5f0 View commit details
    Browse the repository at this point in the history

  7. Ensure that transparent input functionality is correctly feature-flag… 

    …ged.
    @nuttycom
    nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    4dac37f View commit details
    Browse the repository at this point in the history

  8. Merge pull request zcash#480 from zcash/transparent-ovk 

    [ZIP 316] Transparent internal and external ovk
    @nuttycom
    nuttycom authored Jan 23, 2022
    Configuration menu
    Copy the full SHA
    cec128b View commit details
    Browse the repository at this point in the history

  9. Merge remote-tracking branch 'upstream/non-consensus-changes-on-branc… 

    …hid-37519621' into autoshield-poc-daa
    @nuttycom
    nuttycom committed Jan 23, 2022
    Configuration menu
    Copy the full SHA
    4068075 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2022

  1. transparent::ExternalPubKey: impl TryFrom for &[u8; 65].

    @therealyingtong
    therealyingtong committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    8b0c1c4 View commit details
    Browse the repository at this point in the history

  2. Add explicit serialize and deserialize methods to ExternalPubKey 

    The serialization defined by HDWallet for the fields of ExtendedPubKey
is in the opposite field order from what is defined in ZIP 316.
    @nuttycom
    nuttycom committed Jan 24, 2022
    Configuration menu
    Copy the full SHA
    72c2e54 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2022

  1. Move transparent account keys to zcash_primitives.

    @nuttycom
    nuttycom committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    f58d191 View commit details
    Browse the repository at this point in the history

  2. Move OutgoingViewingKey to zcash_primitives::keys

    @nuttycom
    nuttycom committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    0b43535 View commit details
    Browse the repository at this point in the history

  3. Fix doctest compilation.

    @nuttycom
    nuttycom committed Jan 25, 2022
    Configuration menu
    Copy the full SHA
    47fc127 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2022

  1. Derive OVKs from transparent account-level key, not child keys. 

    This also renames a number of legacy key types to better reflect
their intended use.
    @nuttycom
    nuttycom committed Jan 26, 2022
    Configuration menu
    Copy the full SHA
    6fcdfda View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2022

  1. Add serialization and deserialization for AccountPubKey

    @nuttycom
    nuttycom committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    132df78 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: str4d <[email protected]>
    @nuttycom @str4d
    nuttycom and str4d committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    3a20176 View commit details
    Browse the repository at this point in the history

  3. Remove the Wif type; it should not be used. 

    We should attempt to avoid passing spending keys back and forth
across the FFI entirely, but in any case this is no longer the
correct type to use at this boundary; we should use the encoding
of the transparent component of a unified spending key instead.
    @nuttycom
    nuttycom committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    a1e693d View commit details
    Browse the repository at this point in the history

  4. Remove unused zcash_address dependency.

    @nuttycom
    nuttycom committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    544c4ed View commit details
    Browse the repository at this point in the history

  5. Validate ZIP 321 request by roundtrip through the URI format. 

    Co-authored-by: str4d <[email protected]>
    @nuttycom @str4d
    nuttycom and str4d committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    6e11f2d View commit details
    Browse the repository at this point in the history

  6. ExtendedFullViewingKey::chain_code should not be public.

    @nuttycom
    nuttycom committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    4057b06 View commit details
    Browse the repository at this point in the history

  7. Update changelogs.

    @nuttycom
    nuttycom committed Jan 27, 2022
    Configuration menu
    Copy the full SHA
    2f1d3da View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2022

  1. Allow use of internal deprecated pubkey_to_address method.

    @nuttycom
    nuttycom committed Jan 28, 2022
    Configuration menu
    Copy the full SHA
    b3fbf24 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Mark functions that will be made crate-private as deprecated

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    e8e5d94 View commit details
    Browse the repository at this point in the history

  2. Fix order of note deletion relative to transactions being un-mined in… 

    … rewind.
    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    5a75c21 View commit details
    Browse the repository at this point in the history

  3. Use extension traits for transparent-related data api functionality.

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    d0e1f98 View commit details
    Browse the repository at this point in the history

  4. Replace ripemd160 dependency with ripemd

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    8916a16 View commit details
    Browse the repository at this point in the history

  5. Address comments from code review. 

    Co-authored-by: Daira Hopwood <[email protected]>
    @nuttycom @daira
    nuttycom and daira committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3d51c53 View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/non-consensus-changes-on-branc… 

    …hid-37519621' into autoshield-poc-daa
    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    41810e5 View commit details
    Browse the repository at this point in the history

  7. Remove the nullifiers argument from store_decrypted_tx 

    This value can be obtained internally within the implementation
of `store_decrypted_tx` and does not need to be part of the
public API.
    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    2dd0348 View commit details
    Browse the repository at this point in the history

  8. Address comments from code review. 

    Co-authored-by: str4d <[email protected]>
Co-authored-by: Daira Hopwood <[email protected]>
    @nuttycom @str4d @daira
    3 people committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    9c2d485 View commit details
    Browse the repository at this point in the history

  9. zcash_primitives::zip32: Include test vectors for internal key compon… 

    …ents.
    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    cf4c982 View commit details
    Browse the repository at this point in the history

  10. zcash_primitives::zip32::tests: Use internal test vectors.

    @therealyingtong @nuttycom
    therealyingtong authored and nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    0c80399 View commit details
    Browse the repository at this point in the history

  11. Merge pull request zcash#494 from zcash/internal-key-tvs 

    Internal key test vectors
    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    632b9ee View commit details
    Browse the repository at this point in the history

  12. Correct the changelog relating to store_decrypted_tx

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    6b189f1 View commit details
    Browse the repository at this point in the history

  13. Add test vectors for transparent OVKs.

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    b4ff3f3 View commit details
    Browse the repository at this point in the history

  14. Fix incorrect construction of transparent OVKs.

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    1507d1d View commit details
    Browse the repository at this point in the history

  15. Do not delete sent note data in rewind.

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    488d13f View commit details
    Browse the repository at this point in the history

  16. Fix documentation. 

    Co-authored-by: str4d <[email protected]>
    @nuttycom @str4d
    nuttycom and str4d committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    cdd899d View commit details
    Browse the repository at this point in the history

  17. Fix typos.

    @nuttycom
    nuttycom committed Feb 2, 2022
    Configuration menu
    Copy the full SHA
    3699a6d View commit details
    Browse the repository at this point in the history