Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc-only] Minor documentation fix and clarification for the data API #1608

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

daira
Copy link
Contributor

@daira daira commented Nov 4, 2024

  • Fix the documentation for find_account_for_ephemeral_address which included a use of get_known_ephemeral_addresses with incorrect types.
  • Clarify that passing None for the index_range parameter of get_known_ephemeral_addresses is equivalent to passing 0..(1u32 << 31).

* Fix the documentation for `find_account_for_ephemeral_address` which
  included a use of `get_known_ephemeral_addresses` with incorrect types.
* Clarify that passing `None` for the `index_range` parameter of
  `get_known_ephemeral_addresses` is equivalent to passing `0..(1u32 << 31)`.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.30%. Comparing base (c6db09b) to head (d5a17f0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1608   +/-   ##
=======================================
  Coverage   56.30%   56.30%           
=======================================
  Files         148      148           
  Lines       19062    19062           
=======================================
  Hits        10732    10732           
  Misses       8330     8330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nuttycom nuttycom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, doc-only

@nuttycom nuttycom added this pull request to the merge queue Nov 4, 2024
Merged via the queue into zcash:main with commit 8b49ca8 Nov 4, 2024
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants