Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Do not merge] Check CI backtraces 2 #1605

Closed
wants to merge 9 commits into from

Conversation

daira
Copy link
Contributor

@daira daira commented Nov 2, 2024

Just checking whether the .cargo/config.toml approach used in 5672b30 also works.

pacu and others added 9 commits November 2, 2024 18:46
…unds

closes zcash#1411

- Adds min_confirmations to transparent account balances
- Adds a new `transparent_balance_spendability` test to verify
transparent funds spendability.
- cargo clippy + cargo fmt

Refactor: Extract Method on lambda `check_balance`
…test

profile to compile with optimizations by default, but keep full debug info.

This differs from the release profile in the following ways:
- it does not set `lto = true`, which increases compile times without
  substantially speeding up tests;
- it does not set `codegen-units = 1`, which increases compile times and
  is only useful to improve determinism of release builds;
- it does not set `panic = 'abort'`, which is in any case ignored for
  tests.

After this PR, to get results as close as possible to a release build, use
`cargo test --release`.

To speed up compilation and avoid optimizations potentially resulting in
lower-quality debug info, use `cargo test --profile=dev`.

Times on my machine starting from `cargo clean` for each run:
* `cargo test --all-targets --all-features`:
  * 484s (354s build, 130s tests)
* `cargo test --release --all-targets --all-features`:
  * 541s (415s build, 126s tests)
* `cargo test --profile=dev --all-targets --all-features`:
  * 1709s (146s build, 1563s tests)
  * this might still be faster when running individual tests.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
Signed-off-by: Daira-Emma Hopwood <[email protected]>
(instead of only in CI), so that there is no need to set it manually.

You can override this by setting `RUST_BACKTRACE=0`, or
`RUST_BACKTRACE=full` for a full backtrace.

Signed-off-by: Daira-Emma Hopwood <[email protected]>
@daira
Copy link
Contributor Author

daira commented Nov 2, 2024

It does work.

@daira daira closed this Nov 2, 2024
@daira daira deleted the do-not-merge-check-ci-backtrace2 branch November 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants