Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge hotfix/zcash_client_sqlite-0.12.x back to main. #1598

Merged
merged 4 commits into from
Nov 1, 2024

Conversation

nuttycom
Copy link
Contributor

No description provided.

zcash_client_sqlite: Verify that the database is for the correct network before (most) migrations.
…2.x' into hotfix/zcash_client_sqlite-0.12.x-merge
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 20 lines in your changes missing coverage. Please review.

Project coverage is 56.30%. Comparing base (ddf5f1b) to head (6428e8d).
Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
zcash_client_sqlite/src/wallet/init/migrations.rs 55.55% 12 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1598      +/-   ##
==========================================
- Coverage   56.31%   56.30%   -0.02%     
==========================================
  Files         148      148              
  Lines       19026    19062      +36     
==========================================
+ Hits        10714    10732      +18     
- Misses       8312     8330      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@daira daira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@nuttycom nuttycom added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 4b7f973 Nov 1, 2024
28 of 30 checks passed
@nuttycom nuttycom deleted the hotfix/zcash_client_sqlite-0.12.x-merge branch November 1, 2024 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants