Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ZIP-233] Network Sustainability Mechanism: Burning #1567

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

giddie
Copy link

@giddie giddie commented Oct 11, 2024

This mostly consists of the addition of a burn_amount transaction field, introduced in the ZFuture network upgrade. Enabling cfg(zcash_unstable = "zfuture") meant that a lot of TZE code was unnecessarily enabled, so we switched some of those sections to zcash_unstable = "tze" as well as introducing zcash_unstable = "nsm" to keep things separate. The zfuture cfg is now used just to enable the ZFuture network upgrade.

The code for the generated test vectors is available in this PR.

Copy link

codecov bot commented Oct 25, 2024

Codecov Report

Attention: Patch coverage is 41.66667% with 35 lines in your changes missing coverage. Please review.

Project coverage is 61.56%. Comparing base (81d8ad4) to head (0ac99f7).
Report is 64 commits behind head on main.

Files with missing lines Patch % Lines
zcash_primitives/src/transaction/mod.rs 42.85% 16 Missing ⚠️
zcash_primitives/src/transaction/builder.rs 20.00% 8 Missing ⚠️
zcash_primitives/src/transaction/txid.rs 57.14% 6 Missing ⚠️
zcash_client_sqlite/src/wallet.rs 0.00% 4 Missing ⚠️
devtools/src/bin/inspect/transaction.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567      +/-   ##
==========================================
- Coverage   61.62%   61.56%   -0.07%     
==========================================
  Files         148      148              
  Lines       18825    18873      +48     
==========================================
+ Hits        11601    11619      +18     
- Misses       7224     7254      +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants