Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add queues to track the need for transaction enhancement and/or verification of mined status. #1473

Merged
merged 19 commits into from
Aug 9, 2024

Address review comments in `transaction_data_requests`

171cc3d
Select commit
Loading
Failed to load commit list.
Merged

Add queues to track the need for transaction enhancement and/or verification of mined status. #1473

Address review comments in `transaction_data_requests`
171cc3d
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 9, 2024 in 1s

61.10% (+0.27%) compared to 7f7b685

View this Pull Request on Codecov

61.10% (+0.27%) compared to 7f7b685

Details

Codecov Report

Attention: Patch coverage is 73.76238% with 53 lines in your changes missing coverage. Please review.

Project coverage is 61.10%. Comparing base (7f7b685) to head (171cc3d).
Report is 8 commits behind head on main.

Files Patch % Lines
zcash_client_sqlite/src/wallet.rs 67.64% 22 Missing ⚠️
zcash_client_sqlite/src/wallet/transparent.rs 73.80% 11 Missing ⚠️
zcash_client_sqlite/src/lib.rs 83.92% 9 Missing ⚠️
zcash_client_backend/src/data_api.rs 28.57% 5 Missing ⚠️
...e/src/wallet/init/migrations/tx_retrieval_queue.rs 66.66% 4 Missing ⚠️
zcash_client_sqlite/src/wallet/orchard.rs 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1473      +/-   ##
==========================================
+ Coverage   60.82%   61.10%   +0.27%     
==========================================
  Files         140      141       +1     
  Lines       16472    16659     +187     
==========================================
+ Hits        10019    10179     +160     
- Misses       6453     6480      +27

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov