Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zcash_client_sqlite: Align handling of transparent UTXOs with that of shielded notes. #1402

Merged
merged 4 commits into from
Jun 25, 2024

Apply suggestions from code review

9716617
Select commit
Loading
Failed to load commit list.
Merged

zcash_client_sqlite: Align handling of transparent UTXOs with that of shielded notes. #1402

Apply suggestions from code review
9716617
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded Jun 24, 2024 in 0s

85.57% of diff hit (target 63.13%)

View this Pull Request on Codecov

85.57% of diff hit (target 63.13%)

Annotations

Check warning on line 687 in zcash_client_backend/src/data_api.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_backend/src/data_api.rs#L687 

Added line #L687 was not covered by tests

Check warning on line 1238 in zcash_client_sqlite/src/lib.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/lib.rs#L1238 

Added line #L1238 was not covered by tests

Check warning on line 956 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L955-L956 

Added lines #L955 - L956 were not covered by tests

Check warning on line 1170 in zcash_client_sqlite/src/wallet.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet.rs#L1170 

Added line #L1170 was not covered by tests

Check warning on line 25 in zcash_client_sqlite/src/wallet/init/migrations/utxos_to_txos.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/init/migrations/utxos_to_txos.rs#L24-L25 

Added lines #L24 - L25 were not covered by tests

Check warning on line 328 in zcash_client_sqlite/src/wallet/init/migrations/utxos_to_txos.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/init/migrations/utxos_to_txos.rs#L327-L328 

Added lines #L327 - L328 were not covered by tests

Check warning on line 71 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L71 

Added line #L71 was not covered by tests

Check warning on line 77 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L77 

Added line #L77 was not covered by tests

Check warning on line 83 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L81-L83 

Added lines #L81 - L83 were not covered by tests

Check warning on line 91 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L90-L91 

Added lines #L90 - L91 were not covered by tests

Check warning on line 97 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L96-L97 

Added lines #L96 - L97 were not covered by tests

Check warning on line 146 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L145-L146 

Added lines #L145 - L146 were not covered by tests

Check warning on line 159 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L159 

Added line #L159 was not covered by tests

Check warning on line 171 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L171 

Added line #L171 was not covered by tests

Check warning on line 186 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L185-L186 

Added lines #L185 - L186 were not covered by tests

Check warning on line 398 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L397-L398 

Added lines #L397 - L398 were not covered by tests

Check warning on line 466 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L464-L466 

Added lines #L464 - L466 were not covered by tests

Check warning on line 470 in zcash_client_sqlite/src/wallet/transparent.rs

See this annotation in the file changed.

@codecov codecov / codecov/patch

zcash_client_sqlite/src/wallet/transparent.rs#L470 

Added line #L470 was not covered by tests
View more details on Codecov