zcash_primitives: Replace `sapling::redjubjub` with `redjubjub` crate #1056

str4d · 2023-11-30T17:44:28Z

As a side-effect, we remove the ability to verify individual transactions with pre-ZIP 216 rules (which we already removed from zcashd consensus nodes in zcash/zcash#6000 and zcash/zcash#6399, as all pre-ZIP 216 transactions on mainnet and testnet are also valid under ZIP 216).

As a side-effect, we remove the ability to verify individual transactions with pre-ZIP 216 rules (which we already removed from `zcashd` consensus nodes in zcash/zcash#6000 and zcash/zcash#6399, as all pre-ZIP 216 transactions on mainnet are also valid under ZIP 216).

str4d · 2023-11-30T17:56:51Z

zcash_primitives/src/sapling/builder.rs

-                    binding_signature: auth.sigs.bsk.sign(
-                        &sighash,
-                        &mut rng,
-                        VALUE_COMMITMENT_RANDOMNESS_GENERATOR,
-                    ),
+                    binding_signature: auth.sigs.bsk.sign(&mut rng, &sighash),


There was a bug here previously in that this didn't include key prefixing, because we never implemented that inside our redjubjub module (as the original RedDSA draft spec lacked it). I should have used the equivalent of the sapling::spend_sig method here when I added this in #1023 (not that exact method because it also handled re-randomization), but as we haven't cut a release including this API yet, the bug is not in deployed code. The redjubjub crate includes key prefixing.

zcash_primitives/src/transaction/builder.rs

codecov · 2023-11-30T18:06:09Z

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (764127f) 70.62% compared to head (ded09f9) 70.79%.

Files	Patch %	Lines
zcash_primitives/src/sapling/verifier/batch.rs	0.00%	7 Missing ⚠️
zcash_primitives/src/sapling/builder.rs	64.28%	5 Missing ⚠️
zcash_primitives/src/sapling/keys.rs	93.93%	4 Missing ⚠️
zcash_primitives/src/sapling/verifier.rs	0.00%	4 Missing ⚠️
zcash_primitives/src/sapling/verifier/single.rs	0.00%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1056      +/-   ##
==========================================
+ Coverage   70.62%   70.79%   +0.16%     
==========================================
  Files         140      138       -2     
  Lines       13786    13698      -88     
==========================================
- Hits         9737     9698      -39     
+ Misses       4049     4000      -49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

zcash_primitives/src/sapling/verifier/batch.rs

nuttycom

utACK de1ed21

zcash_primitives/src/transaction/builder.rs

zcash_primitives/src/sapling/builder.rs

The Sapling key components specification places more constraints on the values of `ask` and `ak` than general RedJubjub signing and verification keys.

str4d · 2023-12-01T12:14:50Z

~~There's a somewhat concerning test vector failure in zcashd (zcash/zcash#6784 (review)) that I need to debug.~~ EDIT: Nope, it was just a bug in the test vectors.

nuttycom

utACK ded09f9

daira · 2023-12-04T15:33:19Z

zcash_primitives/src/sapling/keys.rs

+#[derive(Clone, Debug)]
+pub struct SpendValidatingKey(redjubjub::VerificationKey<SpendAuth>);
+
+impl From<&SpendAuthorizingKey> for SpendValidatingKey {


Please change this to an explicitly named method.

Filed #1056 .

zcash_primitives/src/sapling/test_vectors/signatures.rs

daira

utACK

str4d force-pushed the 581-use-redjubjub-crate branch from 3878654 to de1ed21 Compare November 30, 2023 17:52

str4d commented Nov 30, 2023

View reviewed changes

zcash_primitives/src/transaction/builder.rs Outdated Show resolved Hide resolved

str4d requested review from nuttycom and daira November 30, 2023 18:02

str4d added this to the Extract sapling-crypto milestone Nov 30, 2023

nuttycom reviewed Nov 30, 2023

View reviewed changes

zcash_primitives/src/sapling/verifier/batch.rs Show resolved Hide resolved

nuttycom previously approved these changes Nov 30, 2023

View reviewed changes

zcash_primitives/src/transaction/builder.rs Outdated Show resolved Hide resolved

daira reviewed Dec 1, 2023

View reviewed changes

zcash_primitives/src/sapling/builder.rs Outdated Show resolved Hide resolved

str4d dismissed nuttycom’s stale review via 4cbeeb9 December 1, 2023 09:47

str4d force-pushed the 581-use-redjubjub-crate branch from 4cbeeb9 to cb72231 Compare December 1, 2023 09:59

zcash_primitives: Introduce newtypes for ask and ak

5ccba3e

The Sapling key components specification places more constraints on the values of `ask` and `ak` than general RedJubjub signing and verification keys.

str4d force-pushed the 581-use-redjubjub-crate branch from cb72231 to 5ccba3e Compare December 1, 2023 11:19

str4d mentioned this pull request Dec 1, 2023

rust: Migrate to latest revision of zcash/librustzcash crates zcash/zcash#6784

Merged

zcash_primitives: Add RedJubjub test vectors

ded09f9

str4d force-pushed the 581-use-redjubjub-crate branch from f9b4c53 to ded09f9 Compare December 1, 2023 14:22

nuttycom approved these changes Dec 1, 2023

View reviewed changes

daira reviewed Dec 4, 2023

View reviewed changes

zcash_primitives/src/sapling/test_vectors/signatures.rs Show resolved Hide resolved

daira mentioned this pull request Dec 4, 2023

Change ask -> ak derivation to use an explicit method rather than From zcash/sapling-crypto#106

Open

daira approved these changes Dec 4, 2023

View reviewed changes

daira merged commit acf1462 into main Dec 4, 2023
31 checks passed

daira deleted the 581-use-redjubjub-crate branch December 4, 2023 18:27

str4d added the C-tech-debt Category: Technical debt that needs to be paid off label Dec 8, 2023

daira mentioned this pull request Dec 19, 2023

Stop using zcash_primitives/src/sapling/redjubjub.rs in favour of redjubjub crate #581

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

zcash_primitives: Replace `sapling::redjubjub` with `redjubjub` crate #1056

zcash_primitives: Replace `sapling::redjubjub` with `redjubjub` crate #1056

str4d commented Nov 30, 2023 •

edited by daira

Loading

str4d Nov 30, 2023 •

edited

Loading

codecov bot commented Nov 30, 2023 •

edited

Loading

nuttycom left a comment

str4d commented Dec 1, 2023 •

edited

Loading

nuttycom left a comment

daira Dec 4, 2023

daira Dec 4, 2023

daira left a comment

zcash_primitives: Replace sapling::redjubjub with redjubjub crate #1056

zcash_primitives: Replace sapling::redjubjub with redjubjub crate #1056

Conversation

str4d commented Nov 30, 2023 • edited by daira Loading

str4d Nov 30, 2023 • edited Loading

Choose a reason for hiding this comment

codecov bot commented Nov 30, 2023 • edited Loading

Codecov Report

nuttycom left a comment

Choose a reason for hiding this comment

str4d commented Dec 1, 2023 • edited Loading

nuttycom left a comment

Choose a reason for hiding this comment

daira Dec 4, 2023

Choose a reason for hiding this comment

daira Dec 4, 2023

Choose a reason for hiding this comment

daira left a comment

Choose a reason for hiding this comment

zcash_primitives: Replace `sapling::redjubjub` with `redjubjub` crate #1056

zcash_primitives: Replace `sapling::redjubjub` with `redjubjub` crate #1056

str4d commented Nov 30, 2023 •

edited by daira

Loading

str4d Nov 30, 2023 •

edited

Loading

codecov bot commented Nov 30, 2023 •

edited

Loading

str4d commented Dec 1, 2023 •

edited

Loading