Release shardtree version 0.6 #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow `no_std` use of `incrementalmerkletree`
nuttycom
force-pushed
the
release/shardtree-0.6
branch
from
03ec3d3 to
3b21d21
Compare
daira
reviewed
Jan 28, 2025
nuttycom
force-pushed
the
release/shardtree-0.6
branch
from
3b21d21 to
04280c4
Compare
str4d
approved these changes
Jan 28, 2025
| @@ -18,7 +18,7 @@ categories = ["algorithms", "data-structures"] | |||
|
|
|||
| [workspace.dependencies] | |||
| # Intra-workspace dependencies | |||
| incrementalmerkletree = { version = "0.8", path = "incrementalmerkletree" } | |||
| incrementalmerkletree = { version = "0.8.1", path = "incrementalmerkletree" } | |||
There was a problem hiding this comment.
As noted in my other comment, I don't think this is actually necessary; cargo will consider 0.8.0 and 0.8.1 as compatible, and if you're not in a no-std environment then 0.8.1 contains nothing that you need (so this is just an overconstraint).
If, by contrast, the being-published shardtree depended on a new API exposed by incrementalmerkletree then this would be the correct way to express the dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.