Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tests and fix some bugs #200

Merged
merged 3 commits into from
Nov 14, 2023
Merged

Improve tests and fix some bugs #200

merged 3 commits into from
Nov 14, 2023

Conversation

ludovicm67
Copy link
Member

This PR is doing the following:

  • send an empty body message in case of error, this fix some unexpected issues with the use of hijackresponse (that we will try to remove in the future)
  • fix an issue in entity renderer plugin for the label loader, where the forEach method is not available due to the replacement of rdf-ext with @zazuko/env
  • improve tests for the entity renderer: it's now able to check if it is rendered as HTML also

Copy link

changeset-bot bot commented Nov 14, 2023

🦋 Changeset detected

Latest commit: fae8107

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@zazuko/trifid-entity-renderer Patch
trifid-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ludovicm67 ludovicm67 merged commit f0a42d0 into main Nov 14, 2023
3 checks passed
@ludovicm67 ludovicm67 deleted the fix-core branch November 14, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant