feat: parsing rules #185
feat: parsing rules #185
Conversation
🦋 Changeset detectedLatest commit: 8ef3c69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #185 +/- ##
==========================================
+ Coverage 96.69% 96.72% +0.02%
==========================================
Files 22 23 +1
Lines 1573 1587 +14
==========================================
+ Hits 1521 1535 +14
Misses 52 52 ☔ View full report in Codecov by Sentry. |
packages/formats/test/index.test.js
Outdated
| .pipe( | ||
| new Transform({ | ||
| objectMode: true, | ||
| transform({ subject, predicate, object, graph }, _, callback) { | ||
| callback(null, $rdf.quad(subject, predicate, object, graph)) | ||
| }, | ||
| }) | ||
| ) |
There was a problem hiding this comment.
Annoyingly, it turns out that the Quads produced by n3 are not working well with rdf-canonize. Feels like this will bite us at some point. Maybe the terms should be repackaged using @rdfjs/data-model in the n3 parser stream?
|
@giacomociti you should not have removed your comment. It forced me to investigate and I found that we do not need that transform! n3 quad defines properties as getters
|
No description provided.