-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: express plugin, deploy plugin #178
Conversation
🦋 Changeset detectedLatest commit: ed0d222 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## cli #178 +/- ##
==========================================
+ Coverage 88.60% 92.90% +4.30%
==========================================
Files 22 25 +3
Lines 886 1043 +157
Branches 86 114 +28
==========================================
+ Hits 785 969 +184
+ Misses 99 73 -26
+ Partials 2 1 -1 ☔ View full report in Codecov by Sentry. |
# Conflicts: # packages/core/index.ts # packages/core/lib/Kopflos.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good (as far as I can tell), I just have a feeling that we're overdoing it with flexibility
I'm happy to discuss now. At which point do you think I'm taking the flexibility too far? |
Introduces plugins feature with two plugins
@kopflos-cms/plugin-deploy-resources
(separate package)Will use talos to deploy a set of paths to the store using the default endpoint
@kopflos-cms/express/middleware
(included in the express package)Let's users register additional middlewares to run before and after kopflos handler