Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: express plugin, deploy plugin #178

Merged
merged 23 commits into from
Oct 25, 2024
Merged

feat: express plugin, deploy plugin #178

merged 23 commits into from
Oct 25, 2024

Conversation

tpluscode
Copy link
Contributor

@tpluscode tpluscode commented Oct 4, 2024

Introduces plugins feature with two plugins

@kopflos-cms/plugin-deploy-resources (separate package)

Will use talos to deploy a set of paths to the store using the default endpoint

@kopflos-cms/express/middleware (included in the express package)

Let's users register additional middlewares to run before and after kopflos handler

Copy link

changeset-bot bot commented Oct 4, 2024

🦋 Changeset detected

Latest commit: ed0d222

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

Attention: Patch coverage is 93.72385% with 15 lines in your changes missing coverage. Please review.

Project coverage is 92.90%. Comparing base (cca64b6) to head (ed0d222).
Report is 25 commits behind head on cli.

Files with missing lines Patch % Lines
packages/cli/index.ts 0.00% 10 Missing ⚠️
packages/core/lib/Kopflos.ts 92.18% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              cli     #178      +/-   ##
==========================================
+ Coverage   88.60%   92.90%   +4.30%     
==========================================
  Files          22       25       +3     
  Lines         886     1043     +157     
  Branches       86      114      +28     
==========================================
+ Hits          785      969     +184     
+ Misses         99       73      -26     
+ Partials        2        1       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tpluscode tpluscode marked this pull request as ready for review October 17, 2024 11:24
@tpluscode tpluscode requested a review from giacomociti October 17, 2024 11:26
Copy link
Contributor

@giacomociti giacomociti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good (as far as I can tell), I just have a feeling that we're overdoing it with flexibility

@tpluscode
Copy link
Contributor Author

I just have a feeling that we're overdoing it with flexibility

I'm happy to discuss now. At which point do you think I'm taking the flexibility too far?

@tpluscode tpluscode merged commit 0502e6a into cli Oct 25, 2024
12 checks passed
@tpluscode tpluscode deleted the plugins branch October 25, 2024 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants