Merge pull request #65 from zazuko/filter-return-value

fix: filter would return object with wrong context
zazuko · Apr 4, 2022 · 075b5b1 · 075b5b1
2 parents dab663e + f98c8ae
commit 075b5b1
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/lib/Clownface.js b/lib/Clownface.js
@@ -200,7 +200,7 @@ class Clownface {
   filter (callback) {
     const pointers = this._context.map(context => Clownface.fromContext(context))
 
-    return Clownface.fromContext(pointers.filter((pointer, index) => callback(pointer, index, pointers)))
+    return Clownface.fromContext(this._context.filter((context, index) => callback(Clownface.fromContext(context), index, pointers)))
   }
 
   /**

diff --git a/test/Clownface/filter.js b/test/Clownface/filter.js
@@ -5,6 +5,7 @@ const clownface = require('../..')
 const loadExample = require('../support/example')
 const rdf = require('../support/factory')
 const Clownface = require('../../lib/Clownface')
+const Context = require('../../lib/Context')
 
 describe('.filter', () => {
   it('should be a function', () => {
@@ -19,6 +20,14 @@ describe('.filter', () => {
     assert(cf.filter(() => true) instanceof Clownface)
   })
 
+  it('should return instance with _context of correct type', () => {
+    const cf = clownface({ dataset: rdf.dataset() }).namedNode()
+
+    const [context] = cf.filter(() => true)._context
+
+    assert(context instanceof Context)
+  })
+
   it('should call the function with Dataset parameter', async () => {
     const cf = clownface({
       dataset: await loadExample(),