Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: update actions, add PR workflow #104

Merged
merged 2 commits into from
Apr 15, 2024
Merged

ci: update actions, add PR workflow #104

merged 2 commits into from
Apr 15, 2024

Conversation

tpluscode
Copy link
Contributor

No description provided.

@tpluscode tpluscode requested a review from ludovicm67 April 10, 2024 09:44
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: d671f81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

ludovicm67
ludovicm67 reviewed Apr 10, 2024
View reviewed changes
Copy link
Member

@ludovicm67 ludovicm67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, maybe we can also try to upgrade to Node 20?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/build.yaml Outdated Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@tpluscode @ludovicm67
ci: use node 20
d671f81 
Co-authored-by: Ludovic Muller <[email protected]>
@tpluscode tpluscode merged commit 526d5cb into main Apr 15, 2024
4 checks passed
@tpluscode tpluscode deleted the ci-build branch April 15, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ludovicm67 ludovicm67 ludovicm67 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tpluscode @ludovicm67