added feature to notify about recorded user interaction #60
Conversation
aryangupta701
commented
Aug 7, 2023
aryangupta701
commented
- added a feature to let the user know weather his interaction has been recorded or not
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
…er to class based Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
aryangupta701
changed the title
|
Now has conflicts |
Signed-off-by: aryangupta701 <[email protected]>
|
This needs to be updated to address conflicts. |
Signed-off-by: Aryan Gupta <[email protected]>
|
ready for review |
|
Just some general feedback. I think this should be optional (it might end up being annoying). I'm also wondering if #63 is a better approach, we could do the notifications in that dialogue instead (showing a list of recorded events would be handy too). I'd have liked to be notified of |
| @@ -17,6 +17,17 @@ | |||
| * See the License for the specific language governing permissions and | |||
| * limitations under the License. | |||
| */ | |||
| import { | |||
There was a problem hiding this comment.
These changes could have been done in its own PR as they are independent of the notifications (I still think worth raising a new PR just adding this but fine if goes together anyway).
|
I think you are right we can provide that notification inside floating window itself. |
