Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frame switches #52

Merged
merged 13 commits into from
Aug 21, 2023
Merged

Frame switches #52

merged 13 commits into from
Aug 21, 2023

Conversation

aryangupta701
Copy link
Contributor

@aryangupta701 aryangupta701 commented Jun 23, 2023

added feature to generate script corresponding to each frame switch

@aryangupta701 aryangupta701 force-pushed the frame-switches branch 3 times, most recently from 5f9636b to 4d3af84 Compare June 26, 2023 14:32
@psiinon
Copy link
Member

psiinon commented Aug 1, 2023

Looks like its failing the lint check

@aryangupta701
Copy link
Contributor Author

Leave this one I will fix this later

@aryangupta701
Copy link
Contributor Author

I want to merge this PR first: #55

Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
Signed-off-by: aryangupta701 <[email protected]>
@psiinon
Copy link
Member

psiinon commented Aug 16, 2023

Now has conflicts

@aryangupta701
Copy link
Contributor Author

will fix it asap

Signed-off-by: aryangupta701 <[email protected]>
@thc202 thc202 enabled auto-merge (squash) August 19, 2023 19:58
@thc202
Copy link
Member

thc202 commented Aug 19, 2023

Thank you!

@thc202 thc202 merged commit 275135d into zaproxy:main Aug 21, 2023
3 checks passed
@aryangupta701 aryangupta701 deleted the frame-switches branch August 21, 2023 08:41
@@ -24,6 +24,7 @@ import {
ZestStatementElementClick,
ZestStatementElementSendKeys,
ZestStatementLaunchBrowser,
ZestStatementSwichToFrame,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo in "Switch".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch (the name of the element is correct).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants