fix: Set success Git commit status in case of skipped checks (#300)

* fix: Set `success` Git commit status in case of skipped checks * do not forget about gitlab
zapier · Oct 29, 2024 · 35dfcf6 · 35dfcf6
1 parent 2d7b205
commit 35dfcf6
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/pkg/commitState.go b/pkg/commitState.go
@@ -30,6 +30,7 @@ func (s CommitState) BareString() string {
 
 var stateString = map[CommitState]string{
 	StateNone:    "",
+	StateSkip:    "Skipped",
 	StateSuccess: "Passed",
 	StateRunning: "Running",
 	StateWarning: "Warning",
@@ -62,6 +63,8 @@ func ParseCommitState(s string) (CommitState, error) {
 		return StateError, nil
 	case "panic":
 		return StatePanic, nil
+	case "skip", "skipped":
+		return StateSkip, nil
 	default:
 		return StateNone, fmt.Errorf("unknown commit state: %s", s)
 

diff --git a/pkg/vcs/github_client/client.go b/pkg/vcs/github_client/client.go
@@ -181,7 +181,7 @@ func toGithubCommitStatus(state pkg.CommitState) *string {
 		return pkg.Pointer("failure")
 	case pkg.StateRunning:
 		return pkg.Pointer("pending")
-	case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone:
+	case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone, pkg.StateSkip:
 		return pkg.Pointer("success")
 	}
 

diff --git a/pkg/vcs/gitlab_client/status.go b/pkg/vcs/gitlab_client/status.go
@@ -69,7 +69,7 @@ func convertState(state pkg.CommitState) gitlab.BuildStateValue {
 		return gitlab.Running
 	case pkg.StateFailure, pkg.StateError, pkg.StatePanic:
 		return gitlab.Failed
-	case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone:
+	case pkg.StateSuccess, pkg.StateWarning, pkg.StateNone, pkg.StateSkip:
 		return gitlab.Success
 	}