41 type information #42

Retro64 · 2017-04-19T08:53:52Z

close #41

Retro64 · 2017-04-19T09:31:53Z

👍

ISO50 · 2017-04-19T11:18:22Z

README.md

@@ -30,7 +30,7 @@ import {
 } from 'lib-oauth-tooling';
 ```

-#### TokenCache(tokenConfig: any, oauthConfig: any)
+#### TokenCache(tokenConfig: { [key : string]: string[] }, oauthConfig: OAuthConfig)


Question: should we move the signature out of the headline?

ISO50 · 2017-04-19T11:20:49Z

integration-test/mock-tooling/index.ts

@@ -83,17 +83,17 @@ describe('mock tooling', () => {

      // when
      let promise = getTokenInfo(tokeninfoEndpoint, 'foo')
-        .then((token: any) => {
+        .then((token: TokenInfo) => {


const + indent

ISO50 · 2017-04-19T11:22:36Z

integration-test/oauth-tooling/getAccessToken.spec.ts

@@ -199,7 +199,7 @@ describe('getAccessToken', () => {
      const responseObject = { 'access_token': '4b70510f-be1d-4f0f-b4cb-edbca2c79d41' };

      nock(host)
-        .post('/access_token?realm=/services', (body) => {
+        .post('/access_token?realm=/services', (body: any) => {


ISO50 · 2017-04-19T11:33:44Z

package.json

  },
  "dependencies": {
-    "body-parser": "^1.16.0",
+    "body-parser": "^1.17.1",


Should we switch to non ^ ~ versions for the library?

ISO50 · 2017-04-19T11:34:49Z

src/TokenCache.ts

@@ -57,8 +52,8 @@ class TokenCache {
   * @param {string} The key configured on the tokenCache instance
   * @return {Promise<string>} the resolved access_token
   */
-  public resolveAccessTokenFactory(key: string): () => Promise<string> {
-    return () => this
+  public resolveAccessTokenFactory(key : string) : () => Promise < string > {


public resolveAccessTokenFactory(key: string): () => Promise<string> {

ISO50 · 2017-04-19T11:36:05Z

src/TokenCache.ts

-  public resolveAccessTokenFactory(key: string): () => Promise<string> {
-    return () => this
+  public resolveAccessTokenFactory(key : string) : () => Promise < string > {
+    return() => this


ISO50 · 2017-04-19T11:37:19Z

src/TokenCache.ts

@@ -70,36 +65,32 @@ class TokenCache {
   * @param tokenName
   * @returns {Promise<T>}
   */
-  get(tokenName: string): Promise<any> {
+  get(tokenName : string) : Promise <TokenInfo> {


get(tokenName: string): Promise<TokenInfo>

ISO50 · 2017-04-19T11:37:42Z

src/TokenCache.ts

-            })
-            .then((tokenInfo: any) => {
+            return getTokenInfo(this.oauthConfig.tokenInfoEndpoint, token.access_token);
+          }).then((tokenInfo : TokenInfo) => {


ISO50 · 2017-04-19T11:42:22Z

src/TokenCache.ts

   */
-  refreshToken(tokenName: string): Promise<any> {
+  refreshToken(tokenName : string) : Promise <TokenInfo> {


ISO50 · 2017-04-19T11:42:29Z

src/TokenCache.ts

@@ -127,13 +118,17 @@ class TokenCache {
   *
   * @returns {Promise<T>}
   */
-  refreshAllTokens(): Promise<any> {
+refreshAllTokens() : Promise <{ [key : string]: TokenInfo }> {


ISO50 · 2017-04-19T11:43:49Z

src/TokenCache.ts

-      });
+    return getTokenInfo(this.oauthConfig.tokenInfoEndpoint, token.access_token).then(validatedToken => {
+      return Promise.resolve(validatedToken);
+    }).catch(() => {


ISO50 · 2017-04-19T11:43:58Z

src/TokenCache.ts

@@ -144,7 +139,7 @@ class TokenCache {
   * @param tokenName
   * @returns {Promise<T>}
   */
-  private validateToken(tokenName: string): Promise<any> {
+  private validateToken(tokenName : string) : Promise <TokenInfo> {


ISO50 · 2017-04-19T11:44:27Z

src/TokenCache.ts

-export {
-  TokenCache
-};
+export {TokenCache};


Like it was or

export { TokenCache };

ISO50 · 2017-04-19T11:44:40Z

src/express-tooling.ts

@@ -77,7 +77,7 @@ function handleOAuthRequestMiddleware(options: any) {
  return function(req: any, res: any, next: Function) {

    // Skip OAuth validation for paths marked as public
-    if (options.publicEndpoints && match(req.originalUrl, options.publicEndpoints)) {
+if (options.publicEndpoints && match(req.originalUrl, new Set(options.publicEndpoints))) {


close #41

ISO50 · 2017-04-19T12:14:40Z

integration-test/mock-tooling/index.ts

+        expect(token).to.equal(validAuthToken);
+        return getTokenInfo(tokeninfoEndpoint, 'foo');
+      })
+      .then((token : TokenInfo) => {


ISO50 · 2017-04-19T12:22:29Z

src/oauth-tooling.ts

+    const userData = JSON.parse(credentials[0]);
+    const clientData = JSON.parse(credentials[1]);
+
+    let bodyParameters: any;


maybe create new issue for new type

close #41

ISO50 · 2017-04-19T13:15:05Z

👍

Retro64 · 2017-04-19T13:15:33Z

👍

Retro64 added 5 commits April 17, 2017 13:51

feat(types): dep update and removed implicit anys

17f7b42

close #41

feat(types): Added type interfaces

541d9cd

close #41

feat(types): Added types

0e79ec7

close #41

feat(types): Added further types

6a44d09

close #41

feat(types): Added more types and corrected README

36ee565

close #41

Retro64 assigned ISO50, bzums and awaltert Apr 19, 2017

fix(test): Fixed unit test

a771102

close #41

ISO50 reviewed Apr 19, 2017

View reviewed changes

src/TokenCache.ts Outdated

export {

TokenCache

};

export {TokenCache};

Copy link

Collaborator

ISO50 Apr 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it was or

export { TokenCache };

ISO50 reviewed Apr 19, 2017

View reviewed changes

refactor(const): let let be const and som formatting

9daa995

close #41

ISO50 reviewed Apr 19, 2017

View reviewed changes

Retro64 added 2 commits April 19, 2017 14:41

refactor(types): review comments

eb6d250

close #41

refactor(types): Further review comments

849fecf

close #41

Retro64 merged commit 8423689 into master Apr 19, 2017

Retro64 deleted the 41-type-information branch January 4, 2018 06:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

41 type information #42

41 type information #42

Retro64 commented Apr 19, 2017

Retro64 commented Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017 •

edited

Loading

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 Apr 19, 2017

ISO50 commented Apr 19, 2017

Retro64 commented Apr 19, 2017

41 type information #42

41 type information #42

Conversation

Retro64 commented Apr 19, 2017

Retro64 commented Apr 19, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ISO50 Apr 19, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ISO50 commented Apr 19, 2017

Retro64 commented Apr 19, 2017

ISO50 Apr 19, 2017 •

edited

Loading