Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide valuable type information #41

Closed
awaltert opened this issue Mar 21, 2017 · 2 comments · Fixed by #42
Closed

Provide valuable type information #41

awaltert opened this issue Mar 21, 2017 · 2 comments · Fixed by #42

Comments

@awaltert
Copy link
Contributor

Type definitions serve multiple purposes. One one side, they help the compiler to determine choices depending of context and enrich the development workflow.
On the other side, do they provide documentation for possible consumers and readers.

In terms of #15 and #30, I would like to suggest to enrich the project with valuable type information to promote the usage of this library.

@bzums
Copy link
Collaborator

bzums commented Apr 18, 2017

@awaltert @Retro64 wrt 541d9cd: regarding the interface definitions of Token and TokenInfo we have to keep in mind that we want to get independent of the oAuth2 server implementation (currently we are "bound" to Zalandos implementation). So we have to find out which properties are mandatory for an oAuth2 server imolementation. Maybe the RFC is helpful (https://tools.ietf.org/html/rfc6749) however i did no research until now in that direction.

Retro64 added a commit that referenced this issue Apr 18, 2017
Retro64 added a commit that referenced this issue Apr 19, 2017
Retro64 added a commit that referenced this issue Apr 19, 2017
Retro64 added a commit that referenced this issue Apr 19, 2017
@Retro64
Copy link
Collaborator

Retro64 commented Apr 19, 2017

@bzums Refactoring should be easier afterwards, if the types are established. Should be done with #39 or #40

Retro64 added a commit that referenced this issue Apr 19, 2017
Retro64 added a commit that referenced this issue Apr 19, 2017
Retro64 added a commit that referenced this issue Apr 19, 2017
feat(types): Added Types
close #41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants