Fix constants.js #29
Closed
Fix constants.js #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thanks for your contribution, it helped me to find the root cause. But I'm sorry, this PR contains too many irrelevant changes, doesn't solve the root cause. Let's follow up in #28 (comment) |
|
Oops sorry some of these changes were made just for my own hotfix in my codebase. I just wanted to submit a PR to bring it to your attention, but agreed on the irrelevant changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is how you want to fix this bug, but since I needed this library for a project I forked this and did the simplest fix I could think of. This works for me in my project but I didn't do any extensive testing.