Fix looping bat files and add support for non-default file extensions #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abekornelis
added
bug
jyganci
reviewed
Nov 25, 2024
jyganci
reviewed
Nov 25, 2024
jyganci
reviewed
Dec 30, 2024
Comment on lines
+25
to
+26
| rem try with default extension of obj | ||
| set z_fext=.obj |
There was a problem hiding this comment.
Lines 25-26. obj should be OBJ.
jyganci
reviewed
Dec 30, 2024
Comment on lines
+25
to
+26
| rem try with default extension of cbl | ||
| set z_fext=.cbl |
There was a problem hiding this comment.
Lines 25-26. cbl should be CBL.
jyganci
reviewed
Dec 30, 2024
| set /P z_file=Hit Enter for more help or suppply name of cbl file to compile: | ||
| :retry | ||
| set z_file= | ||
| set /P z_file=Hit Enter for more help or supply name of cbl file to compile: |
jyganci
reviewed
Dec 30, 2024
Comment on lines
+25
to
+26
| rem try with default extension of cbl | ||
| set z_fext=.cbl |
There was a problem hiding this comment.
Lines 25-26. cbl should be CBL.
jyganci
reviewed
Dec 30, 2024
Comment on lines
+25
to
+26
| rem try with default extension of cbl | ||
| set z_fext=.cbl |
There was a problem hiding this comment.
Lines 25-26. cbl should be CBL.
jyganci
reviewed
Dec 30, 2024
| set /P z_file=Hit Enter for more help or suppply name of cbl file to compile and link: | ||
| :retry | ||
| set z_file= | ||
| set /P z_file=Hit Enter for more help or supply name of cbl file to compile and link: |
jyganci
reviewed
Dec 30, 2024
| @@ -11,20 +11,23 @@ if /I "%1" == "tron" (set z_TraceMode=tron | |||
| set /A z_NestLevel=%z_NestLevel%+1 | |||
| rem ----- Lvl(%z_NestLevel%) Start %0 %1 %2 %3 %4 %5 %6 %7 %8 %9 | |||
|
|
|||
| if /I %1. == . (set /P z_file=Hit Enter for help or suppply name of cbl file to compile: | |||
| if /I %1. == . (set /P z_file=Hit Enter for help or supply name of cbl file to compile: | |||
jyganci
reviewed
Dec 30, 2024
| @@ -11,20 +11,23 @@ if /I "%1" == "tron" (set z_TraceMode=tron | |||
| set /A z_NestLevel=%z_NestLevel%+1 | |||
| rem ----- Lvl(%z_NestLevel%) Start %0 %1 %2 %3 %4 %5 %6 %7 %8 %9 | |||
|
|
|||
| if /I %1. == . (set /P z_file=Hit Enter for help or suppply name of cbl file to compile and link: | |||
| if /I %1. == . (set /P z_file=Hit Enter for help or supply name of cbl file to compile and link: | |||
jyganci
reviewed
Dec 30, 2024
| @@ -11,20 +11,23 @@ if /I "%1" == "tron" (set z_TraceMode=tron | |||
| set /A z_NestLevel=%z_NestLevel%+1 | |||
| rem ----- Lvl(%z_NestLevel%) Start %0 %1 %2 %3 %4 %5 %6 %7 %8 %9 | |||
|
|
|||
| if /I %1. == . (set /P z_file=Hit Enter for help or suppply name of cbl file to compile, link, and execute: | |||
| if /I %1. == . (set /P z_file=Hit Enter for help or supply name of cbl file to compile, link, and execute: | |||
jyganci
reviewed
Dec 30, 2024
| set /P z_file=Hit Enter for more help or suppply name of cbl file to compile, link, and execute: | ||
| :retry | ||
| set z_file= | ||
| set /P z_file=Hit Enter for more help or supply name of cbl file to compile, link, and execute: |
jyganci
reviewed
Dec 30, 2024
| @@ -11,28 +11,31 @@ if /I "%1" == "tron" (set z_TraceMode=tron | |||
| set /A z_NestLevel=%z_NestLevel%+1 | |||
| rem ----- Lvl(%z_NestLevel%) Start %0 %1 %2 %3 %4 %5 %6 %7 %8 %9 | |||
|
|
|||
| if /I %1. == . (set /P z_file=Hit Enter for help or suppply name of obj file to link: | |||
| if /I %1. == . (set /P z_file=Hit Enter for help or supply name of obj file to link: | |||
jyganci
reviewed
Dec 30, 2024
| set /P z_file=Hit Enter for more help or suppply name of obj file to link: | ||
| :retry | ||
| set z_file= | ||
| set /P z_file=Hit Enter for more help or supply name of obj file to link: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #581 bat files for assembly c.a. do not accept non-default file extensions
Fixes Issue #582 bat files go into a loop when input file does not exist
Fixes Issue #590 bldjar.bat procedure fails to copy created jar file