Patch 5 #84
Open
Patch 5 #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'm yearning for a new package under Pypi :^)_ |
yuma-m
reviewed
Jan 22, 2023
| for i in range(0, len(notes)): | ||
| m = notes[i] | ||
| remaining_list = notes[:i] + notes[i + 1:] | ||
| permutations_on_remaining_list = get_all_rotated_notes(remaining_list) |
There was a problem hiding this comment.
I don't think these are regular rotations of a chord. We should keep the backward compatibility for the get_all_rotated_notes function if it is not a bug.
Why do you need this modification? If you think this feature is useful for others, I recommend you create a new function or add a new argument to enable this.
|
|
||
| def test_add4(self): | ||
| chords = find_chords_from_notes(["C", "E", "F", "G"]) | ||
| self.assertEqual(chords, [Chord("Cadd4")]) | ||
| self.assertEqual(chords, [Chord("Cadd4"), Chord("Cadd11")]) |
There was a problem hiding this comment.
I don't think this can be Cadd11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
find_chords_from_notes fixes