Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Update GIZMO frontend to handle newer GIZMO versions #4470

Merged
merged 17 commits into from
Jul 26, 2023
Merged

BUG: Update GIZMO frontend to handle newer GIZMO versions #4470

merged 17 commits into from
Jul 26, 2023

Commits on Jul 25, 2023

  1. Two tweaks for updated GIZMO file snapshots 

    dmetal check - gizmo runs with METALS enabled but all of
	COOL_METAL_LINES_BY_SPECIES, GALSF_FB_FIRE_RPROCESS,
	GALSF_FB_FIRE_AGE_TRACERS, and STARFORGE_FEEDBACK_TRACERS disabled will
	have a metallicity field (aka dmetal) a length 1. This change accounts for
	this possibility

Overriding Gadget _parse_parameter_file - newer versions of GIZMO have changed
	some of the header fields used by yt for determining the cosmology of the
	simulation. Moving this function allows for improved cosmology detection.
	Now check if ComovingIntegrationOn flag exists - if so, use that to
	determine if cosmological run and pull cosmological parameters using
	updated names. Otherwise, fall back to checking for OmegaLambda and setting
	cosmological flag from that.
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    56e748c View commit details
    Browse the repository at this point in the history

  2. Added diagnostic information and bugfix 

    I somehow deleted part of a line before the previous commit. This has been fixed.
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    6802369 View commit details
    Browse the repository at this point in the history

  3. pre-commit changes

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    dfafbe6 View commit details
    Browse the repository at this point in the history

  4. Updated comments 

    Updated comments to point out when the switch occurred.
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    08eaa98 View commit details
    Browse the repository at this point in the history

  5. Update yt/frontends/gizmo/data_structures.py 

    Co-authored-by: Clément Robert <[email protected]>
    @mtryan83 @neutrinoceros
    mtryan83 and neutrinoceros committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3ff5fbf View commit details
    Browse the repository at this point in the history

  6. Update yt/frontends/gizmo/data_structures.py 

    Co-authored-by: Clément Robert <[email protected]>
    @mtryan83 @neutrinoceros
    mtryan83 and neutrinoceros committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    c1095d5 View commit details
    Browse the repository at this point in the history

  7. Responding to comments

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    403ce19 View commit details
    Browse the repository at this point in the history

  8. Removing unnecessary gadget 2 support

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    770da82 View commit details
    Browse the repository at this point in the history

  9. pre-commit check

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    044c3d0 View commit details
    Browse the repository at this point in the history

  10. Adding veto groups 

    It looks like gizmo doesn't export any additional groups besides the Header, unlike Eagle/OWLS. So this should resolve those ambiguities.
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    296cc7b View commit details
    Browse the repository at this point in the history

  11. Accidentally inverted fallback cosmological sim test and removed extr… 

    …aneous setting
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    21cf09b View commit details
    Browse the repository at this point in the history

  12. Switched from try/except to if/else structure. Also added some debugg… 

    …ing information
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    82bd65d View commit details
    Browse the repository at this point in the history

  13. Pre-commit changes

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d6bf2c5 View commit details
    Browse the repository at this point in the history

  14. Updated _is_valid 

    Newer (post Apr 2021) versions of gizmo export GIZMO_version=year_of_last_commit as a header variable. We should use this in preference to checking the gas metallicity, which might not exist. Since the names of the omegas have changed, we don't want to fall back to the gadget loader in the comoving case (in the non-cosmo case it shouldn't matter?)
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    5252fc8 View commit details
    Browse the repository at this point in the history

  15. pre-commit changes

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    883f845 View commit details
    Browse the repository at this point in the history

  16. Added test for new _is_valid and _parse_parameter_file logic 

    New test requires test files gizmo_zeldovich/snapshot_076_XX_gizver.hdf5 where XX is either wi or no. The files can be generated using the gizmo zeldovich pancake test problem with the additional config flags COOLING and METAL. The _no_gizver then has the GIZMO_version header field manually removed. Snapshot 076 was picked randomly.
    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4e39566 View commit details
    Browse the repository at this point in the history

  17. Updated sample data registry

    @mtryan83
    mtryan83 committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    da25c87 View commit details
    Browse the repository at this point in the history