cobalt_shell_apk to build dev.cobalt.coat
#4304
Open
+420
−1,128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is very ugly at the moment. But I'm uploading the draft right now to see if it can help unblock Colin and Bo-Rong. |
johnxwork
force-pushed
the
chroat
branch
2 times, most recently
from
c0db810
to
1a93107
Compare
zhongqiliang
approved these changes
Oct 24, 2024
This new target generate CobaltShell.apk that has dev.cobalt.coat as its package name, and include most of Cobalt's java code. App starts from CobaltActivity now. CobaltActivity inherits from ContentShellActivity now instead of GameActivity. Remember to put treat_warnings_as_errors = false in gn args since Chromium treats java warnings as errors and we have many. There are many TODOs left in this CL and this is only to be served as a prototype to unblock SbPlayer and JS injection. b/374191454
borongc
reviewed
Oct 24, 2024
|
|
||
| <application android:name="dev.cobalt.app.CobaltApplication" | ||
| android:icon="@mipmap/app_icon" | ||
| android:zygotePreloadName="org.chromium.content_public.app.ZygotePreload" |
There was a problem hiding this comment.
Android TV requires android:banner, we should put android:banner="@drawable/app_banner" as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new target generate CobaltShell.apk that has
dev.cobalt.coatas its package name, and include most of Cobalt's java code.App starts from CobaltActivity now. CobaltActivity inherits from ContentShellActivity now instead of GameActivity.
Remember to put treat_warnings_as_errors = false in gn args since Chromium treats java warnings as errors and we have many.
There are many TODOs left in this CL and this is only to be served as a prototype to unblock SbPlayer and JS injection.
b/374191454