[NPLB] Support SetTimeZone extension on Xbox #4281
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
MarekLuxoft
changed the title
| namespace { | ||
|
|
||
| bool SetTimeZone(const char* time_zone_name) { | ||
| Windows::Globalization::Calendar ^ calendar = ref new Windows::Globalization::Calendar(); |
There was a problem hiding this comment.
Why do you need a new object of Calendar? I think you need just update object that you already have in the TimeZoneString class. New method SetTimeZone might be added to that class and this function will be as
bool SetTimeZone (const char* time_zone_name) {
TimeZoneString::Get()->SetTimeZone(time_zone_name);
}
Also you can move TimeZoneString class to this file and rename it to be consistent to its functionality
|
This PR was only as POC, so I closed it to avoid confusion |
In order to test SbTimeZoneGetCurrent(), we need to set a time zone first. Here we add a new time zone API as a starboard extension to set time zone.
b/301980900