Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry pick PR #4047: Add media_support_internal to media_util gn target #4053

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

cobalt-github-releaser-bot
Copy link
Collaborator

Refer to the original PR: #4047

It was missing. It didn't cause any build issues as it's a header file.

Also removed media_is_audio_supported.cc, media_is_supported.cc, and media_is_video_supported.cc from stub/BUILD.gn. They are not implementing any Starboard interfaces (e.g. MediaIsAudioSupported() is internal interface, not exposed to Cobalt) and shouldn't be included in stub/BUILD.gn.

b/361864042

It was missing.  It didn't cause any build issues as it's a header file.

b/361864042

(cherry picked from commit 08cef06)
@cobalt-github-releaser-bot
Copy link
Collaborator Author

Important

There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-4047 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/10582711620 for details.

@xiaomings xiaomings marked this pull request as ready for review August 27, 2024 18:00
@xiaomings xiaomings merged commit 8ce2738 into 24.lts.1+ Aug 27, 2024
433 checks passed
@xiaomings xiaomings deleted the cherry-pick-24.lts.1+-4047 branch August 27, 2024 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants