-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[android] Refine video render algorithm #3269
Open
jasonzhangxx
wants to merge
1
commit into
youtube:main
Choose a base branch
from
jasonzhangxx:improve-frame-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiaomings
reviewed
May 15, 2024
starboard/android/apk/app/src/main/java/dev/cobalt/media/VideoFrameReleaseTimeHelper.java
Outdated
Show resolved
Hide resolved
xiaomings
changed the title
[android] Refine video render algorithm
[android] Refine video renderer algorithm
May 15, 2024
xiaomings
changed the title
[android] Refine video renderer algorithm
[android] Refine video render algorithm
May 15, 2024
jasonzhangxx
force-pushed
the
improve-frame-release
branch
2 times, most recently
from
May 16, 2024 20:25
9cb954a
to
90b791b
Compare
xiaomings
reviewed
May 22, 2024
@@ -54,7 +54,7 @@ class AudioFrameTracker { | |||
// Usually there are very few elements, so std::vector<> is efficient enough. | |||
std::vector<FrameRecord> frame_records_; | |||
int64_t frames_played_adjusted_to_playback_rate_ = 0; | |||
double last_playback_rate_ = 1.0; | |||
double last_playback_rate_ = 0.0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Depends on how confident you are with the change (and the one above), we may or may not want to add a way to turn it off.
jasonzhangxx
force-pushed
the
improve-frame-release
branch
from
May 28, 2024 21:00
90b791b
to
3433677
Compare
1. Improve the precision of timestamp conversion. 2. Set default playback rate to 0 in AudioFrameTracker. b/332858454
jasonzhangxx
force-pushed
the
improve-frame-release
branch
from
May 28, 2024 21:27
3433677
to
b245f3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
b/332858454