Cherry pick PR #3183: Remove some temporarily disabled compiler warnings for clang. #3262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-25.lts.1+-3183 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/9101653421 for details. |
Clean up the disabled compiler warnings. Only add `-Wno-psabi` for old compilers when compiling skia. b/330363799 (cherry picked from commit 56d3eaa)
aee-google
force-pushed
the
cherry-pick-25.lts.1+-3183
branch
from
6f118fe
to
28c186e
Compare
aee-google
approved these changes
May 16, 2024
Taken from #3270
aee-google
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3183
Clean up the disabled compiler warnings.
Only add
-Wno-psabifor old compilers when compiling skia.b/330363799