Cherry pick PR #3224: [media] Make HDR10+ side data type explicit #3229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kMatroskaBlockAdditional is the only side data type supported by Cobalt and its value happens to be 0. The setup of the SbPlayerSampleSideData inside SbPlayerBridge didn't explicitly set the side data type, and relies on the value of kMatroskaBlockAdditional is 0 as it zero-initialized the struct. Now the type is explicitly set. b/276483058 Change-Id: I1d532d2537df02b3fc2af31dda8abb590c396d8e (cherry picked from commit 3c3f1e7)
xiaomings
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3224
kMatroskaBlockAdditional is the only side data type supported by Cobalt and its value happens to be 0. The setup of the SbPlayerSampleSideData inside SbPlayerBridge didn't explicitly set the side data type, and relies on the value of kMatroskaBlockAdditional is 0 as it zero-initialized the struct.
Now the type is explicitly set.
b/276483058
Change-Id: I1d532d2537df02b3fc2af31dda8abb590c396d8e