Cherry pick PR #3159: Introduce new logic for HTMLMediaElement.buffered #3184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This new logic is aligned with upstream Chromium, and with the [HTML spec](https://html.spec.whatwg.org/#dom-media-buffered): * [HTMLMediaElement::BufferedInternal](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/core/html/media/html_media_element.cc;l=3769-3772;drc=eb7475582501e654b3c0bb94be9fdbadfd6b83a0;bpv=0;bpt=0) * [MediaSource::SeekableInternal](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediasource/media_source.cc;l=882-883;drc=d911cdd7a76cdf8895915eae6b88e3bff02a3072;bpv=1;bpt=0) Because this is a potentially disruptive change, the code is gated behind a new H5VCC flag. Use `"MediaElement.EnableUsingMediaSourceBufferedRange"` to enable this change. b/338452286 Change-Id: I52052b2fc5a2c0a1a1c92552434cf53f3bf407e2 (cherry picked from commit a348ae2)
at-ninja
approved these changes
May 7, 2024
….lts.1+-3159 Change-Id: I300daec00c8ff25c72fb86a0d11746a8cb339250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3159
This new logic is aligned with upstream Chromium, and with the HTML spec:
Because this is a potentially disruptive change, the code is gated behind a new H5VCC flag. Use
"MediaElement.EnableUsingMediaSourceBufferedRange"to enable this change.b/338452286
Change-Id: I52052b2fc5a2c0a1a1c92552434cf53f3bf407e2