Cherry pick PR #3179: Rename MediaSource attachment methods #3182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The methods used to attach a MediaSource to an element do not currently align with those used by Chromium. This change renames the methods to have similar names to those used upstream. * [Recent Chromium methods](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/renderer/modules/mediasource/media_source.h;l=118-131;drc=9ed4a90ee6aeaa3c1911d229dec6317d8fe8260d;bpv=0;bpt=0) * [Relevant Chromium commit](https://chromium-review.googlesource.com/c/chromium/src/+/2079384) b/338426134 Change-Id: I0621a93c757d6df4dcb3ad64811707f7c933a13f (cherry picked from commit 43f89aa)
at-ninja
approved these changes
May 7, 2024
….lts.1+-3179 Change-Id: I6812975a485fe0a230739926618519e10fd5ead2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #3179
The methods used to attach a MediaSource to an element do not currently align with those used by Chromium. This change renames the methods to have similar names to those used upstream.
b/338426134
Change-Id: I0621a93c757d6df4dcb3ad64811707f7c933a13f