Cherry pick PR #2672: [media] Reset audio decoder via AudioDecoder::Reset() #2685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Important There were merge conflicts while cherry picking! Check out cherry-pick-24.lts.1+-2672 and fix the conflicts before proceeding. Check the log at https://github.com/youtube/cobalt/actions/runs/8397323605 for details. |
borongc
added a commit
that referenced
this pull request
Mar 30, 2024
…eset() (#2685) Refer to the original PR: #2672 1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|. 2. The PR (#2501) does not clean up |resampler_| and |channel_mixer_|, which causes some tests failed on ps5. This PR cleans up |resampler_| and |channel_mixer_| in AdaptiveAudioDecoder::Reset() to fix the SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures. b/327229953
borongc
force-pushed
the
cherry-pick-24.lts.1+-2672
branch
from
ffee85f
to
7246bcb
Compare
…eset() (#2685) Refer to the original PR: #2672 1. When AdaptiveAudioDecoder() resets |audio_decoder_|, use audio_decoder_->Reset() to reset |audio_decoder_|. 2. The PR (#2501) does not clean up |resampler_| and |channel_mixer_|, which causes some tests failed on ps5. This PR cleans up |resampler_| and |channel_mixer_| in AdaptiveAudioDecoder::Reset() to fix the SbPlayerGetAudioConfigurationTest.MultipleSeeks test failures. b/327229953
borongc
force-pushed
the
cherry-pick-24.lts.1+-2672
branch
from
7246bcb
to
a471ea5
Compare
borongc
approved these changes
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #2672
b/327229953