Cleanup video_stream_ & audio_stream_ after demuxer_ stops #1651
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1651 +/- ##
==========================================
- Coverage 57.56% 57.55% -0.01%
==========================================
Files 1907 1907
Lines 94776 94776
==========================================
- Hits 54558 54551 -7
- Misses 40218 40225 +7 |
xiaomings
reviewed
Sep 28, 2023
borongc
force-pushed
the
native_crash
branch
from
771264e
to
45c480b
Compare
borongc
changed the title
|
Note that the subject no longer applies, as we also set audio_stream_ to nullptr. |
xiaomings
approved these changes
Sep 28, 2023
borongc
changed the title
borongc
force-pushed
the
native_crash
branch
from
45c480b
to
6b09707
Compare
Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907
borongc
force-pushed
the
native_crash
branch
from
6b09707
to
a639b4a
Compare
borongc
added
cp-23.lts.1+
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907 (cherry picked from commit 4c8a0fe)
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Sep 28, 2023
Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907 (cherry picked from commit 4c8a0fe)
borongc
added a commit
that referenced
this pull request
Sep 29, 2023
…uxer_ stops (#1677) Refer to the original PR: #1651 Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907 Co-authored-by: Bo-Rong Chen <[email protected]>
borongc
added a commit
that referenced
this pull request
Oct 2, 2023
…uxer_ stops (#1678) Refer to the original PR: #1651 Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops. b/301284907 Co-authored-by: Bo-Rong Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Native crash due to fault address of video_stream_, cleanup video_stream_ & audio_stream_ after demuxer_ stops.
b/301284907