Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XB1] Refactor test retry loop to rerun net_args #1647

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

TyHolc
Copy link
Contributor

@TyHolc TyHolc commented Sep 27, 2023

b/299672207

Change-Id: Ic90a8805fa9bc6ec7a99ffe55c318f44b82f85cb

b/299672207

Change-Id: Ic90a8805fa9bc6ec7a99ffe55c318f44b82f85cb
@TyHolc TyHolc requested a review from arjungm September 27, 2023 17:57
@TyHolc TyHolc self-assigned this Sep 27, 2023
Copy link
Contributor

@arjungm arjungm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of nits, any resolution is fine

starboard/xb1/tools/xb1_launcher.py Outdated Show resolved Hide resolved
starboard/xb1/tools/xb1_launcher.py Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #1647 (c7d0921) into main (e5b95b8) will not change coverage.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1647   +/-   ##
=======================================
  Coverage   57.57%   57.57%           
=======================================
  Files        1907     1907           
  Lines       94776    94776           
=======================================
  Hits        54569    54569           
  Misses      40207    40207           

see 5 files with indirect coverage changes

Fix incorrect retry attempt count
Add check for if net args were properly applied

b/299672207

Change-Id: I189ab0e14f3a4b4f3fea26a8a899ed7fb45873ac
@TyHolc TyHolc merged commit 03aa6b7 into youtube:main Sep 27, 2023
343 of 344 checks passed
@TyHolc TyHolc deleted the rerun_net_args branch September 27, 2023 21:34
@TyHolc TyHolc added the cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch label Sep 27, 2023
cobalt-github-releaser-bot pushed a commit that referenced this pull request Sep 27, 2023
b/299672207

Change-Id: Ic90a8805fa9bc6ec7a99ffe55c318f44b82f85cb
(cherry picked from commit 03aa6b7)
TyHolc added a commit that referenced this pull request Oct 4, 2023
#1649)

Refer to the original PR: #1647

b/299672207

Change-Id: Ic90a8805fa9bc6ec7a99ffe55c318f44b82f85cb

Co-authored-by: Tyler Holcombe <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cp-24.lts.1+ Cherry Pick to the 24.lts.1+ branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants