Create ScreenShotWriter thread only when necessary #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jellefoks
force-pushed
the
screenshot_thread_only_when_necessary
branch
from
5f2027b
to
9ca30cd
Compare
Codecov Report
@@ Coverage Diff @@
## main #1644 +/- ##
==========================================
- Coverage 57.58% 57.55% -0.03%
==========================================
Files 1907 1907
Lines 94776 94776
==========================================
- Hits 54573 54553 -20
- Misses 40203 40223 +20 |
jellefoks
force-pushed
the
screenshot_thread_only_when_necessary
branch
2 times, most recently
from
03b2800
to
86f56b6
Compare
sherryzy
reviewed
Sep 28, 2023
This delays creating the ScreenShotWriter until the first time a ScreenShot is requested.
jellefoks
force-pushed
the
screenshot_thread_only_when_necessary
branch
from
86f56b6
to
af5a145
Compare
sherryzy
approved these changes
Sep 28, 2023
cobalt-github-releaser-bot
pushed a commit
that referenced
this pull request
Oct 3, 2023
This delays creating the ScreenShotWriter until the first time a ScreenShot is requested. b/302358421 (cherry picked from commit e77a231)
jellefoks
added a commit
that referenced
this pull request
Oct 4, 2023
…ary (#1712) Refer to the original PR: #1644 This delays creating the ScreenShotWriter until the first time a ScreenShot is requested. b/302358421 Co-authored-by: Jelle Foks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This delays creating the ScreenShotWriter until the first time a
ScreenShot is requested.
b/302358421