Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add platform RDK to launcher framework #1547

Merged
merged 1 commit into from
Sep 28, 2023
Merged

Add platform RDK to launcher framework #1547

merged 1 commit into from
Sep 28, 2023

Conversation

maxz-lab
Copy link
Contributor

Added launcher infrastructure for AH212 RDK (v5) as independent RDK platform.

b/293172465

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Sep 13, 2023 •
edited
Loading

Datadog Report

Branch report: maxz-lab-rdk-independent
Commit report: 37f6429

✅ cobalt: 0 Failed, 0 New Flaky, 26579 Passed, 1 Skipped, 4m 40.05s Wall Time

@codecov

This comment was marked as resolved.

Sign in to view
@maxz-lab maxz-lab requested a review from oxve September 15, 2023 15:57
oxve
oxve reviewed Sep 15, 2023
View reviewed changes
starboard/evergreen/shared/launcher.py Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Show resolved Hide resolved
starboard/rdk/launcher.py Show resolved Hide resolved
starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/tools/testing/test_runner.py Show resolved Hide resolved
starboard/tools/testing/test_runner.py Outdated Show resolved Hide resolved
starboard/tools/testing/test_runner.py Outdated Show resolved Hide resolved
@maxz-lab
Copy link
Contributor Author

Updated a new patch to address all the comments from Oxve.

@maxz-lab maxz-lab force-pushed the maxz-lab-rdk-independent branch 3 times, most recently from 37f6429 to 8f19a92 Compare September 20, 2023 21:21
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Sep 20, 2023 •
edited
Loading

Datadog Report

Branch report: maxz-lab-rdk-independent
Commit report: 31b9366

✅ cobalt: 0 Failed, 0 New Flaky, 29549 Passed, 1 Skipped, 10m 19.88s Wall Time

@maxz-lab maxz-lab force-pushed the maxz-lab-rdk-independent branch 2 times, most recently from 394ba28 to 8a80fe5 Compare September 24, 2023 04:25
oxve
oxve reviewed Sep 26, 2023
View reviewed changes
Copy link
Contributor

@oxve oxve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR doesn't really match the contents. Can you rephrase to make it clear that it adds a new platform to the launcher framework?

starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
starboard/evergreen/shared/launcher.py Outdated Show resolved Hide resolved
oxve
oxve reviewed Sep 26, 2023
View reviewed changes
starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/rdk/gyp_configuration.py Outdated Show resolved Hide resolved
starboard/rdk/launcher.py Outdated Show resolved Hide resolved
starboard/rdk/test_filters.py Outdated Show resolved Hide resolved
@maxz-lab maxz-lab changed the title Enable evergreen test on RDK platform Add platform RDK to launcher framework Sep 26, 2023
oxve
oxve approved these changes Sep 27, 2023
View reviewed changes
starboard/evergreen/shared/launcher.py Show resolved Hide resolved
starboard/rdk/test_filters.py Show resolved Hide resolved
@maxz-lab
Add RDK platform to launcher framework
78e90ce 
Added launcher infrastructure for AH212 RDK (v5) as independent
RDK platform.
Share the retry.py between RDK and Raspi.
Also filtered some tests in base_unittests test.

b/293172465
@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Sep 27, 2023 •
edited
Loading

Datadog Report

Branch report: maxz-lab-rdk-independent
Commit report: 78e90ce

✅ cobalt: 0 Failed, 0 New Flaky, 29549 Passed, 1 Skipped, 9m 59.78s Wall Time

@maxz-lab maxz-lab merged commit 477b864 into main Sep 28, 2023
402 of 403 checks passed
@maxz-lab maxz-lab deleted the maxz-lab-rdk-independent branch October 4, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxve oxve oxve approved these changes

@andrewsavage1 andrewsavage1 andrewsavage1 approved these changes

Assignees
No one assigned
Labels
on_device
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maxz-lab @oxve @andrewsavage1