Cherry pick PR #1431: Define wchar_t according to __WCHAR_TYPE__ #1462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niranjanyardi
approved these changes
Sep 20, 2023
b/298211986 b/246854012 Windows platform modular builds don't work with the current definition of wchar_t for c files. Setting wchar_t according to the predefined C macro __WCHAR_TYPE__ ensures that wchar_t is defined correctly. Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401 (cherry picked from commit 474b3db)
niranjanyardi
force-pushed
the
24.lts.1+-1431
branch
from
769973f
to
43d5bd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the original PR: #1431
b/298211986
b/246854012
Windows platform modular builds don't work with the current definition of wchar_t for c files.
Setting wchar_t according to the predefined C macro WCHAR_TYPE ensures that wchar_t is defined correctly.
Error shows up here: b/246854012#comment41 and was discussed in go/lbreview/260401