Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download xml results and logs from on-device tests #1120

Closed
wants to merge 16 commits into from
Closed

Conversation

oxve
Copy link
Contributor

@oxve oxve commented Aug 2, 2023

Android and raspi emit junit xml files and logs that Mobile Harness pulls from the devices
and uploads to the specified path on GCS.
Download those files and upload them as artifacts so the test report uploader will pick them up.

b/288331664
b/290997541

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented Aug 2, 2023

Datadog Report

Branch report: android-xml-final
Commit report: 31f63d8

cobalt: 0 Failed, 0 New Flaky, 33824 Passed, 0 Skipped, 26m 28.08s Wall Time

@codecov
Copy link

codecov bot commented Aug 3, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.54%. Comparing base (686e489) to head (31f63d8).
Report is 35 commits behind head on main.

Current head 31f63d8 differs from pull request most recent head 169f243

Please upload reports for the commit 169f243 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1120      +/-   ##
==========================================
- Coverage   57.90%   56.54%   -1.37%     
==========================================
  Files        1780     1899     +119     
  Lines       85217    94143    +8926     
==========================================
+ Hits        49347    53232    +3885     
- Misses      35870    40911    +5041     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaidokert kaidokert requested a review from isarkis August 5, 2023 06:39
Copy link
Member

@kaidokert kaidokert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me.

@oxve oxve marked this pull request as draft February 13, 2024 17:33
@oxve oxve requested review from kaidokert and isarkis May 16, 2024 23:45
@oxve oxve marked this pull request as ready for review May 16, 2024 23:45
@oxve
Copy link
Contributor Author

oxve commented May 16, 2024

This change needs an internal change to be deployed before landing.

@datadog-cobalt-youtube
Copy link

datadog-cobalt-youtube bot commented May 17, 2024

Datadog Report

Branch report: android-xml-final
Commit report: 1415e9b
Test service: cobalt

✅ 0 Failed, 34338 Passed, 6 Skipped, 6m 30.74s Total Time

@oxve oxve requested a review from isarkis May 17, 2024 22:45
@oxve oxve requested a review from isarkis May 20, 2024 22:22
@oxve oxve changed the title Download junit xml files from MH Download xml results and logs from on-device tests May 23, 2024
@oxve oxve requested a review from isarkis May 23, 2024 22:13
@oxve
Copy link
Contributor Author

oxve commented May 23, 2024

I pushed a new commit that accommodates the internal change that also uploads the logs files to GCS.

@kaidokert kaidokert enabled auto-merge (squash) May 24, 2024 21:32
@kaidokert kaidokert disabled auto-merge May 24, 2024 21:32
oxve added 5 commits May 28, 2024 22:39
Android and raspi emit junit xml files that MH pulls from the devices and uploads to GCS.
Download those files and upload them as artifacts so the test report uploader will pick them up.
This way the plugin can upload multiple files to the destination without
path manipulation.
oxve added 5 commits May 28, 2024 22:39
Multiple uploads to the same artifact name will overwrite previous versions.
@oxve oxve added the on_device label Jun 11, 2024
oxve added 4 commits June 11, 2024 23:02
Change-Id: Ic1ff049f6c01523a97acbd0a372b421f5e0fcee9
Change-Id: Ie1dfefec4a258b6a46474495a3451fc190e12817
@kaidokert
Copy link
Member

Pretty sure this PR is stale by now !

@oxve oxve closed this Oct 1, 2024
@oxve oxve deleted the android-xml-final branch October 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants