Skip to content

Commit

Permalink
remove log messages
Browse files Browse the repository at this point in the history
Change-Id: I339d92414abd8374958913945f9e31e20763d191
  • Loading branch information
madhurajayaraman committed Jun 17, 2024
1 parent a69354a commit aafdce7
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 9 deletions.
8 changes: 0 additions & 8 deletions net/cert/test_root_certs_unittest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

#include "net/cert/test_root_certs.h"

#include "starboard/common/log.h"
#include "base/files/file_path.h"
#include "build/build_config.h"
#include "net/base/features.h"
Expand Down Expand Up @@ -94,27 +93,21 @@ TEST(TestRootCertsTest, OverrideTrust) {
// certificate should not yet be trusted.
int flags = 0;
CertVerifyResult bad_verify_result;
SB_LOG(INFO) << "override trust 96";
scoped_refptr<CertVerifyProc> verify_proc(CreateCertVerifyProc());
SB_LOG(INFO) << "override trust 99";
int bad_status = verify_proc->Verify(
test_cert.get(), "127.0.0.1", /*ocsp_response=*/std::string(),
/*sct_list=*/std::string(), flags, CertificateList(), &bad_verify_result,
NetLogWithSource());
SB_LOG(INFO) << "override trust 104";
EXPECT_NE(OK, bad_status);
SB_LOG(INFO) << "override trust 106";
EXPECT_NE(0u, bad_verify_result.cert_status & CERT_STATUS_AUTHORITY_INVALID);
EXPECT_FALSE(bad_verify_result.is_issued_by_known_root);

// Add the root certificate and mark it as trusted.
scoped_refptr<X509Certificate> root_cert =
ImportCertFromFile(GetTestCertsDirectory(), kRootCertificateFile);
ASSERT_TRUE(root_cert);
SB_LOG(INFO) << "override trust 114";
ScopedTestRoot scoped_root(root_cert.get());
EXPECT_FALSE(test_roots->IsEmpty());
SB_LOG(INFO) << "override trust 117";

// Test that the certificate verification now succeeds, because the
// TestRootCerts is successfully imbuing trust.
Expand All @@ -124,7 +117,6 @@ TEST(TestRootCertsTest, OverrideTrust) {
/*sct_list=*/std::string(), flags, CertificateList(), &good_verify_result,
NetLogWithSource());
EXPECT_THAT(good_status, IsOk());
SB_LOG(INFO) << "override trust 126";
EXPECT_EQ(0u, good_verify_result.cert_status);
EXPECT_FALSE(good_verify_result.is_issued_by_known_root);

Expand Down
1 change: 0 additions & 1 deletion starboard/shared/iso/impl/directory_get_next.h
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@
#include <dirent.h>
#include <errno.h>

#include "starboard/common/log.h"
#include "starboard/common/string.h"
#include "starboard/configuration_constants.h"
#include "starboard/file.h"
Expand Down

0 comments on commit aafdce7

Please sign in to comment.