Skip to content

Commit

Permalink
Revert "Change Android DPad key mapping (#3322)" (#4261)
Browse files Browse the repository at this point in the history
This reverts commit 92d1bef.

We're reverting the change to the DPad key mapping.  
While intended for YTS certification, it unintentionally caused issues
with game controller functionality. A potential fix exists, but it
carries a high risk of further problems. To ensure stability, we've
opted to revert to the previous mapping.

See the bug for more details

b/370840137

Change-Id: I71d243aa2087e746edd40ba6437b5181bd7cd13a

Co-authored-by: Colin Liang <[email protected]>
  • Loading branch information
zhongqiliang and Colin Liang authored Oct 16, 2024
1 parent 5015486 commit 1352872
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions starboard/android/shared/input_events_generator.cc
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,15 @@ SbKey AInputEventToSbKey(GameActivityKeyEvent* event) {

// D-pad
case AKEYCODE_DPAD_UP:
return kSbKeyUp;
return kSbKeyGamepadDPadUp;
case AKEYCODE_DPAD_DOWN:
return kSbKeyDown;
return kSbKeyGamepadDPadDown;
case AKEYCODE_DPAD_LEFT:
return kSbKeyLeft;
return kSbKeyGamepadDPadLeft;
case AKEYCODE_DPAD_RIGHT:
return kSbKeyRight;
return kSbKeyGamepadDPadRight;
case AKEYCODE_DPAD_CENTER:
return kSbKeyReturn;
return kSbKeyGamepad1;

// Game controller
case AKEYCODE_BUTTON_A:
Expand Down

0 comments on commit 1352872

Please sign in to comment.