Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Divider 제작 #16

Merged
merged 4 commits into from
Jan 19, 2025
Merged

Divider 제작 #16

merged 4 commits into from
Jan 19, 2025

Conversation

Gael-Android
Copy link
Contributor

Summary

Handy Divider 입니다.
기본 색상은 bg/basic/strong 이지만 수정할 수 있게 해두었고
width 가 있을 경우에는 너비를 지정하지만 없다면 기본 fillMaxWidth 입니다.

Describe your changes

스크린샷 2024-11-22 오후 2 28 33

To reviewers

@yourssu/android-maintainer

@Gael-Android Gael-Android self-assigned this Nov 22, 2024
Copy link
Member

@cometj03 cometj03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase 한 번 하고 머지 해주세요!

@Gael-Android
Copy link
Contributor Author

@kangyuri1114 수정했습니다

Copy link
Member

@kangyuri1114 kangyuri1114 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다! Navigation도 merge 후 반영부탁드려요!

@Gael-Android
Copy link
Contributor Author

@leeeyubin 어프루브 부탁드려요~

Copy link
Member

@leeeyubin leeeyubin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨어요!!

@Gael-Android Gael-Android merged commit e39245a into main Jan 19, 2025
@Gael-Android Gael-Android deleted the feature/gael/divider branch January 19, 2025 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants