password mandatory when converting to pkcs#8 #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't seem to cause regressions from the tests, but it's an API break, so it would require a major version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @youmark,
As the goal of this library is to support - and promote? - the use of password-protected private key with strong encryption algorithms, I suggest you make the password parameter mandatory when converting to PKCS#8.
Those who prefer to keep their private key in plaintext can still use MarshalPrivateKey, where the password remains optional.
Also, this way, ConvertPrivateKeyToPKCS8 and MarshalPrivateKey have two different purposes.
Regards,
Philippe.