Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: depend on tower util feature #316

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

shikhar
Copy link
Contributor

@shikhar shikhar commented Oct 19, 2024

Currently, a compilation error comes up when patching an application that depends on google-cloud-spanner to unreleased tonic, but this will be a problem with tonic 0.13.

tower's util feature is needed because of

use tower::util::Either;

https://docs.rs/tower/0.4.13/tower/util/enum.Either.html

(AFAIU, feature unification somehow prevents an error with tonic 0.12.x)

@yoshidan yoshidan added the safe to test safe to test label Oct 19, 2024
@yoshidan yoshidan merged commit 391dd00 into yoshidan:main Oct 19, 2024
8 of 9 checks passed
@yoshidan
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
safe to test safe to test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants