Updates unmaintained tokio-retry to tokio-retry2 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could not run Github Actions on my side |
|
Thanks! |
Do you want me to do the improvements I mentioned? |
|
Yes, I was thanking you for this PR, |
|
Will do soon-ish |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tokio-retryhas been unmaintained for over 3 years now, so this new crate, tokio-retry2, is being used by my project.It has new features like the ability to early exit with wrapping errors (RetryError::Permanent), or continue the retry loop (
RetryError::Transient). I noticed that for the specific caseshould_retryhas been used, using RetryError should be simple. As well a notification on fail system (which was not included in this PR, but can be easily done replacingRetry::spawn(..)withRetry::spawn_notify(..)) . In the case ofRetryIfnotification is expected by default, and I noticed the codebase was using a notification system withtrace, so I moved it to the notification function of it.